This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add taint-tracking for packages inside text/*#320
Merged
max-schaefer merged 5 commits intogithub:mainfrom Sep 11, 2020
Merged
Conversation
Contributor
|
Needs tests, otherwise looks good! I'll be testing these to see what impact they have on lgtm.com over the course of this week. |
Contributor
Author
|
Awesome! Thanks. |
Contributor
|
We'll need to make sure the various escaper functions that are now generally considered taint conductors are properly considered sanitisers by the queries that care about a particular sort of injection, but I didn't see many false positives so we're likely in a good state. LGTM. |
smowton
approved these changes
Sep 11, 2020
max-schaefer
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeboxcommands:Part of #167