This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Move to stdlib and expand taint-tracking for io and io/ioutil packages#340
Merged
smowton merged 7 commits intogithub:mainfrom Sep 23, 2020
Merged
Move to stdlib and expand taint-tracking for io and io/ioutil packages#340smowton merged 7 commits intogithub:mainfrom
io and io/ioutil packages#340smowton merged 7 commits intogithub:mainfrom
Conversation
Contributor
Author
|
I removed the byte/rune read/write taint tracking; is that ok? |
Contributor
|
Sounds good to me |
Contributor
|
I note the frontend errors consistency check is failing again here -- try a |
smowton
reviewed
Sep 17, 2020
| (inp.isReceiver() and outp.isParameter(0)) | ||
| or | ||
| // signature: func (Reader).Read(p []byte) (n int, err error) | ||
| this.implements("io", "Reader", "Read") and |
Contributor
There was a problem hiding this comment.
Are the PipeReader.Read etc rules redundant because of this? Similarly ReaderAt and so on?
Contributor
Author
There was a problem hiding this comment.
Removed from io package. Will do in another PR for all the other packages.
da9da24 to
c4a493f
Compare
smowton
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeboxcommands:Part of #167