Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- lib/rules/async-currenttarget.js: Evaluated as low risk
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
| const data = await fetch(url) | ||
|
|
||
| // But now, event.currentTarget will be null | ||
| const text = event.currentTarget.getAttribute('data-text') |
There was a problem hiding this comment.
event.currentTarget might be null after the await call. Add a null check before accessing getAttribute.
Suggested change
| const text = event.currentTarget.getAttribute('data-text') | |
| if (event.currentTarget === null) return; | |
| const text = event.currentTarget.getAttribute('data-text') |
manuelpuyol
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #589
This now updates the rules as ESLint has updated the rules API for custom rules: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
Tested and looks like it's now working as expected: