Merged
Conversation
…com/wangzihuacool/gh-ost into add-rocksdb-as-transactional-engine
ghost
reviewed
Nov 25, 2022
ghost
left a comment
There was a problem hiding this comment.
This looks great! Thanks @wangzihuacool!
I've asked a question about the migration test changes in my review. Would you mind also adding PerconaServer-8.0.21 to the list of versions in .github/workflows/replica-tests.yml? I've merged github/gh-ost-ci-env#14, so we can enable the RocksDB migration tests in CI 😄
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
@wangzihuacool thanks for your work on this PR 🙇. I've added a few comments in-line
timvaillancourt
previously approved these changes
Nov 27, 2022
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot @wangzihuacool! 🙏
ghost
suggested changes
Nov 28, 2022
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
ghost
approved these changes
Nov 29, 2022
ghost
left a comment
There was a problem hiding this comment.
Thanks @wangzihuacool, this is brilliant! 🚀
timvaillancourt
approved these changes
Nov 29, 2022
Contributor
|
FYI, this introduced a regression: #1262 |
|
Coping other phones |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1189
Description:
Add support for rocksdb as transactional engine