Conversation
bbcd1e8 to
75a346b
Compare
cd83cbd to
b06c1cd
Compare
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
Thanks @morgo! I like the flag approach 👍
Added a few comments inline
ghost
reviewed
Nov 15, 2022
ghost
left a comment
There was a problem hiding this comment.
I've added some thoughts around docs/output - the actual code looks good to me though 👍
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
…t-instant-ddl * origin/attempt-instant-ddl: Update go/logic/migrator.go
timvaillancourt
previously approved these changes
Nov 15, 2022
timvaillancourt
approved these changes
Nov 15, 2022
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
LGTM 👍. Thanks again @morgo!
ghost
approved these changes
Nov 16, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1198
Description
This adds support for attempting INSTANT DDL from MySQL 8.0 before applying gh-ost's original algorithm. It is disabled by default for now (per suggestion), although in future it makes sense to enable by default and hide behind version detection.
script/cibuildreturns with no formatting errors, build errors or unit test errors.