Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- localtests/test.sh: Language not supported
- script/docker-gh-ost-replica-tests: Language not supported
- script/gh-ost-test-mysql-master: Language not supported
- script/gh-ost-test-mysql-replica: Language not supported
Comments suppressed due to low confidence (3)
localtests/docker-compose.yml:3
- The environment variable TEST_MYSQL_IMAGE is not defined within the docker-compose file. Ensure that this variable is set in the environment where the docker-compose command is run.
image: $TEST_MYSQL_IMAGE
localtests/docker-compose.yml:11
- The MySQL container is configured to use port 3307, which is non-standard and may conflict with other services. Ensure this port is available or consider using the default MySQL port 3306.
- '3307:3307'
localtests/docker-compose.yml:23
- The MySQL replica container is configured to use port 3308, which is non-standard and may conflict with other services. Ensure this port is available or consider using the default MySQL port 3306.
- '3308:3308'
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
alexisjcarr
approved these changes
Dec 13, 2024
ericyan
approved these changes
Dec 13, 2024
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a docker container setup for running the replica tests in
localtest/, since it can be hard to get dbdeployer working locally, and it is no longer maintained. Eventually we can use docker for the replica tests in CI as well.Tested with
mysql:8.0.39on darwin arm64 and linux amd64.Usage:
script/cibuildreturns with no formatting errors, build errors or unit test errors.