Improved connection type logging#515
Merged
timvaillancourt merged 4 commits intogithub:masterfrom Feb 8, 2021
Merged
Conversation
Collaborator
|
@akshaychhajed thanks for your contribution and sorry for the delay Could you resolve the merge conflicts with this PR above? I can test and merge this PR once the changes are up-to-date |
Contributor
Author
|
@timvaillancourt looks like I am little late for this. Let me know if I can help. |
Collaborator
@akshaychhajed I've fixed the merge conflicts and this change LGTM 👍. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #461
Description
This PR adds connection type to logs. It helps distinguish connection type (inspector, streamer and applier)
Fixes #461
script/cibuildreturns with no formatting errors, build errors or unit test errors.