add --skip-strict-mode option#712
Merged
shlomi-noach merged 2 commits intogithub:masterfrom Mar 24, 2019
Merged
Conversation
shlomi-noach
approved these changes
Feb 17, 2019
Contributor
shlomi-noach
left a comment
There was a problem hiding this comment.
looks good. It is unfortunate that this flag is needed 🤷♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #711
Description
This PR adds a --skip-strict-mode option which enables the user to tell gh-ost not to enfore STRICT_ALL_TABLES sql_mode mode on copy and applier (which affect other sql_mode options such as ERROR_FOR_DIVISION_BY_ZERO, NO_ZERO_DATE, and NO_ZERO_IN_DATE.
script/cibuildreturns with no formatting errors, build errors or unit test errors.