Adds error checking for an err variable that was left unchecked#810
Merged
timvaillancourt merged 1 commit intogithub:masterfrom Aug 14, 2020
yaserazfar:check_unchecked_errors
Merged
Adds error checking for an err variable that was left unchecked#810timvaillancourt merged 1 commit intogithub:masterfrom yaserazfar:check_unchecked_errors
timvaillancourt merged 1 commit intogithub:masterfrom
yaserazfar:check_unchecked_errors
Conversation
timvaillancourt
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to an issue, but is adding an error check where an err variable was set but not checked. This could potentially help find errors when developing in the future.
Description
This PR adds an error checks for an err variable which was assigned but never checked.
script/cibuildreturns with no formatting errors, build errors or unit test errors.This issues was found using CodeLingo - codelingo.io