Generated column as part of UNIQUE (or PRIMARY) KEY#919
Merged
timvaillancourt merged 21 commits intogithub:masterfrom May 24, 2021
Merged
Generated column as part of UNIQUE (or PRIMARY) KEY#919timvaillancourt merged 21 commits intogithub:masterfrom
timvaillancourt merged 21 commits intogithub:masterfrom
Conversation
Actions/Workflow: upload artifact
Support a complete ALTER TABLE statement in --alter
handle driver timeout error
Updates from upstream 2020 10
Initial commit: towards setting up a test suite Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copying AUTO_INCREMENT value to ghost table
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
At this time this PR appears to contain many more commits than actually changed; this is because there's still other outstanding requests to merge upstream. For reference, the specific changes to this PR are https://github.com/openark/gh-ost/pull/13/files |
timvaillancourt
approved these changes
Jan 27, 2021
Collaborator
timvaillancourt
left a comment
There was a problem hiding this comment.
Thanks @shlomi-noach 👍
2 tasks
Collaborator
|
@shlomi-noach 👋 this is being tested now! Could you re-base this branch so it's ready to merge after a few days of testing? 🙇 |
Contributor
Author
|
Rebased! |
Collaborator
|
Thanks @shlomi-noach this passed tests for over a week. Merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmission of openark#13 from downstream.
Supporting the case where any unique key, and in particular the
PRIMARY KEY, includes aGENERATEDcolumn.A user with a large database deployment, who initially reported the issue, has confirmed the fix works as expected.
script/cibuildreturns with no formatting errors, build errors or unit test errors.