Skip to content

Add 'applier' and 'inspector' commands to server#951

Merged
timvaillancourt merged 8 commits intogithub:masterfrom
timvaillancourt:add-server-cmd-hosts
Apr 4, 2021
Merged

Add 'applier' and 'inspector' commands to server#951
timvaillancourt merged 8 commits intogithub:masterfrom
timvaillancourt:add-server-cmd-hosts

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Apr 2, 2021 •
edited
Loading

Description

This PR introduces two new commands for the unix-socket/TCP server:

  1. applier - list the MySQL hostname of the applier
  2. inspector - list the MySQL hostname of the inspector

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

cc @gtowey / @TeeKraken / @shlomi-noach

@timvaillancourt timvaillancourt changed the title Add server cmd hosts Add 'applier' and 'inspector' commands to server Apr 2, 2021
shlomi-noach
shlomi-noach approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Apr 3, 2021
@timvaillancourt
Copy link
Collaborator Author

timvaillancourt commented Apr 3, 2021

Example output w/applier+inspector on same host:

tim@Tims-MacBook-Pro /tmp % echo applier | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log
tim@Tims-MacBook-Pro /tmp % echo inspector | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log

That's the final tweak before merging

@timvaillancourt timvaillancourt merged commit d95dda3 into github:master Apr 4, 2021
@timvaillancourt timvaillancourt deleted the add-server-cmd-hosts branch April 4, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashiq rashiq rashiq approved these changes

@TeeKraken TeeKraken Awaiting requested review from TeeKraken

+2 more reviewers

@gtowey gtowey gtowey approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v1.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@timvaillancourt @gtowey @rashiq @shlomi-noach