Fix a bug that cause local test helper to fail when searching an emulator with an older cloud SDK#33
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
/cc @shinfan |
|
That's odd that googlebot doesn't recognize your CLA status... |
currentVersion may be null when using an older GCLOUD SDK without the searched emulator.
|
CLAs look good, thanks! |
I created this PR directly via the Github UI which used, aozarov@users.noreply.github.com, as the Author. I fixed that by amending the commit. |
|
ping. Was this issue fixed in a different PR? We need to get it in for fixing the gcloud-java pubsub-alpha branch build. |
|
LGTM. Thanks for catching & fixing the issue. |
|
I don't have permission to merge for this repository. BTW, I highly recommend configuring Travis for this project to build every PR, so you can be sure |
currentVersion may be null when using an older GCLOUD SDK without the searched emulator.