Never require 'body' for requests.#718
Merged
busunkim96 merged 1 commit intogoogleapis:masterfrom Jul 17, 2019
Merged
Conversation
Contributor
Author
|
If you forget to pass a body to an API that has required properties, the server will throw an error. Example: ( |
tswast
approved these changes
Jul 17, 2019
|
How long will it take before this is visible to the client lib? Passing body={} in a request is very dangerous Python behavior. This broke a bunch of our automation. |
Contributor
Author
|
@TxBillbr I'll cut a release today -- apologies for the disruption this caused! |
|
Thanks much for the prompt handling. I have just released a local work-around for our local library that tries the correct method and if it throws an error tries with the body={}. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713.
Never require that a
bodybe passed in a request. Validation ofbodywill be left to the server.