Add compute engine credentials by theacodes · Pull Request #22 · googleapis/google-auth-library-python

theacodes · 2016-10-14T21:25:15Z

No description provided.

google/auth/compute_engine/__init__.py

+
+__all__ = [
+    'Credentials'
+]


google/auth/compute_engine/__init__.py

+
+
+__all__ = [
+    'Credentials'


google/auth/compute_engine/credentials.py

+        # pylint: disable=attribute-defined-outside-init
+        # (pylint doesn't recognize that this is defined in ScopedCredentials)
+        self._scopes = _helpers.string_to_scopes(info['scopes'])
+        # pylint: enable=attribute-defined-outside-init


tests/compute_engine/test_credentials.py

+from google.auth.compute_engine import credentials
+
+
+class TestCredentials:


tests/compute_engine/test_credentials.py

+class TestCredentials:
+    @pytest.fixture(autouse=True)
+    def credentials(self):
+        self.credentials = credentials.Credentials()


tests/compute_engine/test_credentials.py

+        assert not self.credentials.requires_scopes
+
+    def test_create_scoped_fails(self):
+        pass


tests/compute_engine/test_credentials.py

+class TestCredentials(object):
+    @pytest.fixture(autouse=True)
+    def credentials(self):
+        self.credentials = credentials.Credentials()


dhermes · 2016-10-16T16:58:39Z

LGTM (after resolving the def credentials rename and whatever you decide on __all__)

theacodes added this to the 1.0.0 milestone Oct 14, 2016

theacodes assigned bjwatson, dhermes and elibixby Oct 14, 2016

Add compute_engine.Credentials

c0b0484

theacodes force-pushed the compute-credentials branch from a18411f to c0b0484 Compare October 14, 2016 21:32

dhermes reviewed Oct 15, 2016

View reviewed changes

Address review comments

6f5ef5e

dhermes reviewed Oct 16, 2016

View reviewed changes

tests/compute_engine/test_credentials.py

class TestCredentials(object):

@pytest.fixture(autouse=True)

def credentials(self):

self.credentials = credentials.Credentials()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Address review comments

99c414b

theacodes merged commit a042549 into master Oct 17, 2016

theacodes deleted the compute-credentials branch October 17, 2016 17:48

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned bjwatson, dhermes and elibixby Oct 11, 2018

		from google.auth.compute_engine import credentials


		class TestCredentials:



		__all__ = [
		'Credentials'

Conversation

theacodes commented Oct 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants