Add oauth2 credentials by theacodes · Pull Request #24 · googleapis/google-auth-library-python

theacodes · 2016-10-14T22:32:18Z

No description provided.

google/oauth2/credentials.py

+optional `refresh token`_.
+
+Obtaining the initial access and refresh token is outside of the scope of this
+module. Consult `rfc6749 section 4.1` for complete details on the Authorization


google/oauth2/credentials.py

+from google.oauth2 import _client
+
+
+class Credentials(credentials.Scoped, credentials.Credentials):


google/oauth2/credentials.py

+    def __init__(self, token, refresh_token=None, token_uri=None,
+                 client_id=None, client_secret=None, scopes=None):
+        """
+        Args:


google/oauth2/credentials.py

+            client_secret(str): The OAuth 2.0 client secret. Must be specified
+                for refresh, can be left as None if the token can not be
+                refreshed.
+            scopes (Union[str, Sequence]): The scopes that were originally used


google/oauth2/credentials.py

+                can not request additional scopes after authorization.
+        """
+        super(Credentials, self).__init__()
+        self.token = token


google/oauth2/credentials.py

+
+    @_helpers.copy_docstring(credentials.Credentials)
+    def refresh(self, request):
+        access_token, refresh_token, expiry, _ = _client.refresh_grant(


tests/oauth2/test_credentials.py

+from google.oauth2 import credentials
+
+
+class TestCredentials:


tests/oauth2/test_credentials.py

+
+
+class TestCredentials:
+    token_uri = 'https://example.com/oauth2/token'


tests/oauth2/test_credentials.py

+        self.credentials = credentials.Credentials(
+            token=None, refresh_token='refresh_token',
+            token_uri=self.token_uri, client_id='client_id',
+            client_secret='client_secret')


tests/oauth2/test_credentials.py

+
+    def test_create_scoped(self):
+        with pytest.raises(NotImplementedError):
+            assert credentials == self.credentials.with_scopes('email')


dhermes · 2016-10-16T17:03:33Z

LGTM, be sure to file the Credentials naming issue before merging

theacodes

@dhermes LGTY?

google/oauth2/credentials.py

+    def __init__(self, token, refresh_token=None, token_uri=None,
+                 client_id=None, client_secret=None, scopes=None):
+        """
+        Args:


tests/oauth2/test_credentials.py

+from google.oauth2 import credentials
+
+
+class TestCredentials:


theacodes · 2016-10-17T17:46:32Z

Oh I see you already said so, merging.

Add oauth2 credentials

33f6206

theacodes added this to the 1.0.0 milestone Oct 14, 2016

theacodes assigned dhermes Oct 14, 2016

dhermes reviewed Oct 15, 2016

View reviewed changes

Address review comments

39ff039

theacodes mentioned this pull request Oct 17, 2016

Consider credential class naming scheme #28

Closed

theacodes commented Oct 17, 2016

View reviewed changes

theacodes merged commit 10ec7e9 into master Oct 17, 2016

theacodes deleted the oauth2-credentials branch October 17, 2016 17:46

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned dhermes Oct 11, 2018

		from google.oauth2 import _client


		class Credentials(credentials.Scoped, credentials.Credentials):



		class TestCredentials:
		token_uri = 'https://example.com/oauth2/token'

Conversation

theacodes commented Oct 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 16, 2016

Uh oh!

theacodes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Oct 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants