Add service account credentials by theacodes · Pull Request #25 · googleapis/google-auth-library-python

theacodes · 2016-10-14T22:50:08Z

No description provided.

google/oauth2/service_account.py

+
+from google.auth import _helpers
+from google.auth import crypt
+from google.auth import credentials


google/oauth2/service_account.py

+
+    def __init__(self, signer, service_account_email, token_uri, scopes=None,
+                 subject=None, additional_claims=None):
+        """


google/oauth2/service_account.py

+        self._service_account_email = service_account_email
+        self._subject = subject
+        self._token_uri = token_uri
+        self._additional_claims = additional_claims or {}


google/oauth2/service_account.py

+        email = info['client_email']
+        key_id = info['private_key_id']
+        private_key = info['private_key']
+        token_uri = info['token_uri']


google/oauth2/service_account.py

+
+        Args:
+            filename (str): The path to the service account json file.
+            kwargs: Additional arguments to pass to the constructor.


tests/oauth2/test_service_account.py

+        assert credentials._additional_claims['meta'] == 'data'
+
+    def test_from_service_account_bad_key(self):
+        info = dict(SERVICE_ACCOUNT_INFO)


tests/oauth2/test_service_account.py

+        with pytest.raises(ValueError) as excinfo:
+            service_account.Credentials.from_service_account_info(info)
+
+        assert excinfo.match(r'No key could be detected')


tests/oauth2/test_service_account.py

+        info = {}
+
+        with pytest.raises(KeyError):
+            service_account.Credentials.from_service_account_info(info)


tests/oauth2/test_service_account.py

+    def test_sign_bytes(self):
+        to_sign = b'123'
+        signature = self.credentials.sign_bytes(to_sign)
+        crypt.verify_signature(to_sign, signature, PUBLIC_CERT_BYTES)


tests/oauth2/test_service_account.py

+
+        # Check jwt grant call.
+        assert jwt_grant_mock.called
+        request, token_uri, assertion = jwt_grant_mock.call_args[0]


tests/oauth2/test_service_account.py

+    @pytest.fixture(autouse=True)
+    def credentials(self, signer):
+        self.credentials = service_account.Credentials(
+            signer, self.SERVICE_ACCOUNT_EMAIL, self.TOKEN_URI)


dhermes · 2016-10-16T16:53:46Z

LGTM after def credentials rename?

Add service account credentials

9f76090

theacodes added this to the 1.0.0 milestone Oct 14, 2016

theacodes assigned dhermes Oct 14, 2016

dhermes reviewed Oct 15, 2016

View reviewed changes

Jon Wayne Parrott added 3 commits October 15, 2016 12:21

Address review comments

fbfc051

Fix lint

e9acc56

Fix docstring

75e6e72

dhermes reviewed Oct 16, 2016

View reviewed changes

tests/oauth2/test_service_account.py

@pytest.fixture(autouse=True)

def credentials(self, signer):

self.credentials = service_account.Credentials(

signer, self.SERVICE_ACCOUNT_EMAIL, self.TOKEN_URI)

This comment was marked as spam.

Sign in to view

This was referenced Oct 16, 2016

Add compute engine credentials #22

Merged

Add JWT credentials #21

Merged

Address review comments

3d5f028

theacodes merged commit ab9eba3 into master Oct 17, 2016

theacodes deleted the service-account-credentials branch October 17, 2016 17:50

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned dhermes Oct 11, 2018

Conversation

theacodes commented Oct 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants