feat: defines internal utils for OAuth client Auth and error handling#594
Merged
busunkim96 merged 5 commits intogoogleapis:byoidfrom Sep 3, 2020
bojeil-google:oauth-utils
Merged
feat: defines internal utils for OAuth client Auth and error handling#594busunkim96 merged 5 commits intogoogleapis:byoidfrom bojeil-google:oauth-utils
busunkim96 merged 5 commits intogoogleapis:byoidfrom
bojeil-google:oauth-utils
Conversation
This defines internal utilities to handle: - OAuth client authentication - Standard OAuth error response parsing into OAuthError exception.
Contributor
|
@bojeil-google Base branch has been adjusted to |
Contributor
|
@bojeil-google It may be helpful to join the org |
busunkim96
reviewed
Sep 2, 2020
google/oauth2/utils.py
Outdated
| from google.auth import exceptions | ||
|
|
||
|
|
||
| def enum(**named_values): |
Contributor
There was a problem hiding this comment.
Is it possible to use Python provided enums? https://cpython-test-docs.readthedocs.io/en/latest/library/enum.html
Contributor
Author
There was a problem hiding this comment.
Ok. I tried it out with the backport enum34 package . It seems to work locally.
busunkim96
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defines internal utilities to handle: