Add google.auth.credentials - the public interfaces for credentials by theacodes · Pull Request #8 · googleapis/google-auth-library-python

theacodes · 2016-10-04T21:45:50Z

@nathanielmanistaatgoogle this is the section you indicated you wanted to give input on. PTAL.

theacodes · 2016-10-04T21:53:09Z

I am unsure if I should leave the scopes property as is (completely private) or make it a public read-only property.

dhermes · 2016-10-04T22:08:34Z

I vote for public read-only. I'm holding off a review here until you tell me to look @jonparrott

theacodes · 2016-10-04T22:09:50Z

Sgtm, gonna let Nathaniel chime in first.

On Tue, Oct 4, 2016, 3:08 PM Danny Hermes notifications@github.com wrote:

I vote for public read-only. I'm holding off a review here until you tell
me to look @jonparrott https://github.com/jonparrott

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc-0omIhmwrF0HlyVl8t7Mu8-MKApks5qws5igaJpZM4KOMdL
.

theacodes · 2016-10-10T20:06:58Z

@nathanielmanistaatgoogle ping, this is now blocking.

dhermes · 2016-10-10T20:09:08Z

@jonparrott rebase?

theacodes · 2016-10-10T20:09:16Z

@dhermes doing it now.

theacodes · 2016-10-10T20:14:26Z

Rebased.

google/auth/credentials.py

theacodes · 2016-10-14T21:07:57Z

@nathanielmanistaatgoogle after discussing with @dhermes offline, I'm gonna go ahead and merge this so we can unblock reviewing some concrete classes.

We can still continue to discuss here and I'll send follow-up PRs to make changes. This is all fluid until 1.0. Unless there is a very significant change I don't anticipate the impact on concrete classes to be large.

theacodes added this to the 1.0.0 milestone Oct 4, 2016

theacodes assigned bjwatson and dhermes Oct 4, 2016

theacodes force-pushed the credentials-abc branch from b00bfcc to 84a8f6b Compare October 10, 2016 20:12

theacodes mentioned this pull request Oct 10, 2016

[Discussion] post 4.0.0 refactor googleapis/oauth2client#597

Closed

nathanielmanistaatgoogle reviewed Oct 10, 2016

View reviewed changes

Jon Wayne Parrott and others added 7 commits October 14, 2016 13:41

Add google.auth.credentials - the public interfaces for credentials

902f761

Fix inline hyperlink

db9aa4c

Fix utcnow usage

78c615c

Address review comments

cd526b9

Make scopes public read-only, restrict type to sequence

2aa80a6

Rename mixin classes

2b83967

Remove unneeded use of byte strings

602be67

theacodes force-pushed the credentials-abc branch from e27eca9 to 602be67 Compare October 14, 2016 20:41

theacodes mentioned this pull request Oct 14, 2016

Add JWT credentials #21

Merged

dhermes approved these changes Oct 14, 2016

View reviewed changes

Address offline review comments

f522fc4

theacodes merged commit 71ce2a0 into master Oct 14, 2016

theacodes deleted the credentials-abc branch October 14, 2016 21:08

theacodes unassigned bjwatson and dhermes Oct 11, 2018

renovate-bot mentioned this pull request May 31, 2025

chore(deps): update all dependencies #1759

Closed

1 task

Conversation

theacodes commented Oct 4, 2016

Uh oh!

theacodes commented Oct 4, 2016

Uh oh!

dhermes commented Oct 4, 2016

Uh oh!

theacodes commented Oct 4, 2016

Uh oh!

theacodes commented Oct 10, 2016

Uh oh!

dhermes commented Oct 10, 2016

Uh oh!

theacodes commented Oct 10, 2016

Uh oh!

theacodes commented Oct 10, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Oct 14, 2016

Uh oh!

Reviewers