feat: Pluggable auth support by renkelvin · Pull Request #995 · googleapis/google-auth-library-python

renkelvin · 2022-03-17T16:18:38Z

Adding pluggable auth support.

* Port identity pool credentials * access_token retrieved * -> pluggable * Update pluggable.py * Create test_pluggable.py * Unit tests * Address pr issues

* Add file cache * feat: add output file cache support

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lsirac

First pass. I didn't review the tests. Thanks Chuan!

google/auth/pluggable.py

renkelvin · 2022-03-18T17:51:57Z

Hmm, I can't push to the pluggable branch. I may need to create a new pr from my fork.

renkelvin · 2022-03-18T18:04:56Z

Hey @arithmetic1728, mind giving me the temporary write access to this repo? It should make the review much easier.

arithmetic1728 · 2022-03-18T18:39:23Z

@renkelvin you need to join https://github.com/googleapis first, then I can give you temporary write access

renkelvin · 2022-03-18T21:44:53Z

@renkelvin you need to join https://github.com/googleapis first, then I can give you temporary write access

Done joining https://github.com/googleapis

arithmetic1728 · 2022-03-19T00:29:14Z

@renkelvin I just gave you the write access, let me know if it doesn't work.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

renkelvin · 2022-03-19T15:10:02Z

@renkelvin I just gave you the write access, let me know if it doesn't work.

It works, thanks!

google/auth/pluggable.py

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…-library-python into pluggable

renkelvin · 2022-03-23T18:30:15Z

@arithmetic1728 Any ideas how can I add pytest_subprocess as a dev dependency just for testing purpose? Thanks! https://source.cloud.google.com/results/invocations/e6b81a67-add0-4bfa-9089-fe92b4cc7007/targets/github%2Fgoogle-auth-library-python/tests

arithmetic1728 · 2022-03-23T18:57:40Z

@renkelvin I think you can add it here: https://github.com/googleapis/google-auth-library-python/blob/main/testing/requirements.txt

…-library-python into pluggable

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

arithmetic1728 · 2022-05-05T06:31:35Z

You can run the following easily-to-fail kokoro tests locally before pushing to github. This will save a lot of time. (Don't worry about the kokoro system-3.7 failure - It is caused by expired creds. I will update the creds once your PR is ready to merge).

lint: python -m nox -s lint
If lint fails, run python -m nox -s blacken to format the files, then re-run lint. If it can pass, don't forget to add and commit the changes.

cover: python -m nox -s cover

nox cover

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…-library-python into pluggable

renkelvin · 2022-05-09T05:43:05Z

You can run the following easily-to-fail kokoro tests locally before pushing to github. This will save a lot of time. (Don't worry about the kokoro system-3.7 failure - It is caused by expired creds. I will update the creds once your PR is ready to merge).

lint: python -m nox -s lint If lint fails, run python -m nox -s blacken to format the files, then re-run lint. If it can pass, don't forget to add and commit the changes.

cover: python -m nox -s cover

Thanks @arithmetic1728! The CI passes now.

arithmetic1728 · 2022-05-09T22:15:44Z

LGTM

@sai-sunder-s would you like to take another look?
@renkelvin I will fix the system test in a separate PR when we are ready to check in.

🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.6...v2.7.0) (2022-06-07) ### Features * add experimental enterprise cert support ([#1052](#1052)) ([dda7dda](dda7dda)) * add experimental GDCH support ([#1022](#1022)) ([5367aac](5367aac)) * Pluggable auth support ([#995](#995)) ([62daa73](62daa73)) ### Bug Fixes * validate urls for external accounts ([#1031](#1031)) ([61b1f15](61b1f15)) ### Reverts * pluggable auth support [#995](#995) ([#1039](#1039)) ([513d999](513d999)) * revert experimental GDCH support ([#1022](#1022)) ([#1042](#1042)) ([c720995](c720995)) ### Documentation * fix changelog header to consistent size ([#1046](#1046)) ([e64d084](e64d084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Chuan Ren added 2 commits March 1, 2022 14:14

feat: Add Pluggable auth support (#988)

63ad5e9

* Port identity pool credentials * access_token retrieved * -> pluggable * Update pluggable.py * Create test_pluggable.py * Unit tests * Address pr issues

feat: Add file caching (#990)

f36e5e8

* Add file cache * feat: add output file cache support

renkelvin requested review from a team, arithmetic1728 and sai-sunder-s as code owners March 17, 2022 16:18

🦉 Updates from OwlBot post-processor

28cfefc

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

renkelvin changed the title ~~Pluggable auth support~~ feat: Pluggable auth support [Do not merge] Mar 17, 2022

arithmetic1728 requested a review from lsirac March 17, 2022 18:15

arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 17, 2022

Merge branch 'main' into pluggable

4b1e956

lsirac reviewed Mar 17, 2022

View reviewed changes

Update pluggable.py

d7f4980

🦉 Updates from OwlBot post-processor

7092170

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lsirac reviewed Mar 21, 2022

View reviewed changes

google/auth/pluggable.py Outdated Show resolved Hide resolved

google/auth/pluggable.py Outdated Show resolved Hide resolved

google/auth/pluggable.py Outdated Show resolved Hide resolved

Chuan Ren and others added 6 commits March 22, 2022 18:11

Update pluggable.py

5246463

🦉 Updates from OwlBot post-processor

62246d6

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update setup.py

d0e4294

Merge branch 'pluggable' of https://github.com/googleapis/google-auth…

0ceda64

…-library-python into pluggable

Update setup.py

6618271

Update setup.py

1f38c45

Chuan Ren added 2 commits March 23, 2022 12:35

pytest_subprocess

be1cfc9

timeout

97bd209

Chuan Ren and others added 6 commits May 4, 2022 17:45

pytest-subprocess

9a4a518

Merge branch 'pluggable' of https://github.com/googleapis/google-auth…

d6ab6f0

…-library-python into pluggable

🦉 Updates from OwlBot post-processor

ac27e4a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into pluggable

484d07f

lint

d71587e

Update pluggable.py

3d40268

Chuan Ren and others added 7 commits May 8, 2022 02:11

nox cover

8bfae0a

nox cover

🦉 Updates from OwlBot post-processor

245b610

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lint

25b5446

Update test_pluggable.py

34126ef

🦉 Updates from OwlBot post-processor

15d7a79

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update test_pluggable.py

1e5a89a

Merge branch 'pluggable' of https://github.com/googleapis/google-auth…

f423446

…-library-python into pluggable

arithmetic1728 approved these changes May 9, 2022

View reviewed changes

sai-sunder-s approved these changes May 10, 2022

View reviewed changes

arithmetic1728 changed the title ~~feat: Pluggable auth support [Do not merge]~~ feat: Pluggable auth support May 10, 2022

Merge branch 'main' into pluggable

e0b966a

arithmetic1728 merged commit 62daa73 into main May 10, 2022

arithmetic1728 deleted the pluggable branch May 10, 2022 18:30

release-please bot mentioned this pull request May 10, 2022

chore(main): release 2.7.0 #1036

Merged

arithmetic1728 added a commit that referenced this pull request May 10, 2022

revert: pluggable auth support #995

c321e39

arithmetic1728 mentioned this pull request May 10, 2022

revert: pluggable auth support #995 #1039

Merged

arithmetic1728 added a commit that referenced this pull request May 11, 2022

revert: pluggable auth support #995 (#1039)

513d999

renkelvin restored the pluggable branch May 27, 2022 17:28

renkelvin mentioned this pull request May 27, 2022

feat: pluggable auth support #1045

Merged

Conversation

renkelvin commented Mar 17, 2022

Uh oh!

lsirac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renkelvin commented Mar 18, 2022

Uh oh!

renkelvin commented Mar 18, 2022

Uh oh!

arithmetic1728 commented Mar 18, 2022

Uh oh!

renkelvin commented Mar 18, 2022

Uh oh!

arithmetic1728 commented Mar 19, 2022

Uh oh!

renkelvin commented Mar 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renkelvin commented Mar 23, 2022

Uh oh!

arithmetic1728 commented Mar 23, 2022

Uh oh!

arithmetic1728 commented May 5, 2022

Uh oh!

renkelvin commented May 9, 2022

Uh oh!

arithmetic1728 commented May 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants