Add custom port support to LocalPubsubHelper by shinfan · Pull Request #956 · googleapis/google-cloud-java

shinfan · 2016-04-25T19:32:41Z

No description provided.

- compatible with GAX 0.0.11 - better documentation

…java into pubsub-alpha

coveralls · 2016-04-25T19:38:37Z

Coverage decreased (-0.01%) to 84.988% when pulling ddd117d on shinfan:pubsub-alpha into d829e97 on GoogleCloudPlatform:pubsub-alpha.

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubsubHelper.java

  private final LocalServiceHelper serviceHelper;
-  private final List<String> gcloudCommand;
-  private final URL emulatorUrl;
+


shinfan · 2016-04-25T19:48:05Z

PTAL

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubsubHelper.java

-        new DownloadableEmulatorRunner(Arrays.asList(BIN_NAME), emulatorUrl, MD5_CHECKSUM);
+        new DownloadableEmulatorRunner(Arrays.asList(BIN_NAME, BIN_CMD_PORT_FLAG + port),
+                                       EMULATE_URL,
+                                       MD5_CHECKSUM);


mziccard · 2016-04-25T19:51:15Z

Added a bunch of nits.

Also please @shinfan could you rebase these changes so that we can avoid the merge commit in this PR (1c9065e)?

coveralls · 2016-04-25T19:52:54Z

Coverage decreased (-0.02%) to 84.978% when pulling f5d4df7 on shinfan:pubsub-alpha into d829e97 on GoogleCloudPlatform:pubsub-alpha.

coveralls · 2016-04-25T19:58:05Z

Coverage decreased (-0.01%) to 84.988% when pulling f5d4df7 on shinfan:pubsub-alpha into d829e97 on GoogleCloudPlatform:pubsub-alpha.

shinfan · 2016-04-25T20:06:55Z

Also please @shinfan could you rebase these changes so that we can avoid the merge commit in this PR (1c9065e)?

I am planning to do a squash & merge. Does it make any difference if I rebase in this case? All sub commits will be squashed into one single PR commit.

coveralls · 2016-04-25T20:14:29Z

Coverage decreased (-0.02%) to 84.978% when pulling 2637346 on shinfan:pubsub-alpha into d829e97 on GoogleCloudPlatform:pubsub-alpha.

mziccard · 2016-04-25T20:18:13Z

I am planning to do a squash & merge. Does it make any difference if I rebase in this case? All sub commits will be squashed into one single PR commit.

No rebase is needed then. Just please avoid merges in PRs if not strictly necessary as it makes harder to understand what's going on. Looks good to me, feel free to merge. Thanks for doing that!

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubsubHelper.java

+  private static final String BIN_CMD_PORT_FLAG = "--port=";

  // Downloadable emulator settings
  private static final String FILENAME = "pubsub-emulator-20160113-2.zip";


…956) * chore(deps): update dependency com.google.cloud:libraries-bom to v26 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [3.6.6](googleapis/java-dlp@v3.6.5...v3.6.6) (2022-08-04) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#955](googleapis/java-dlp#955)) ([fef48dc](googleapis/java-dlp@fef48dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.1.0](googleapis/java-vision@v3.0.2...v3.1.0) (2022-08-09) ### Features * Add TextDetectionParams.advanced_ocr_options ([#962](googleapis/java-vision#962)) ([178e4a4](googleapis/java-vision@178e4a4)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#955](googleapis/java-vision#955)) ([c4fdb49](googleapis/java-vision@c4fdb49)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#958](googleapis/java-vision#958)) ([0a11239](googleapis/java-vision@0a11239)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#960](googleapis/java-vision#960)) ([8d62c20](googleapis/java-vision@8d62c20)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#952](googleapis/java-vision#952)) ([3400667](googleapis/java-vision@3400667)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#956](googleapis/java-vision#956)) ([89b114c](googleapis/java-vision@89b114c)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#959](googleapis/java-vision#959)) ([3885ac8](googleapis/java-vision@3885ac8)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#961](googleapis/java-vision#961)) ([99996d4](googleapis/java-vision@99996d4)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#963](googleapis/java-vision#963)) ([1f7e3ba](googleapis/java-vision@1f7e3ba)) * update spring.version to v2.7.2 ([#951](googleapis/java-vision#951)) ([8e4c6ab](googleapis/java-vision@8e4c6ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.3 (#956) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | `2.11.2` -> `2.11.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/compatibility-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/confidence-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://togithub.com/psf/requests), [changelog](https://togithub.com/psf/requests/blob/master/HISTORY.md)) | `==2.27.1` -> `==2.28.1` | [![age](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/compatibility-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/confidence-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9 build: enable Speech v2 client library generation PiperOrigin-RevId: 477910378 Source-Link: https://togithub.com/googleapis/googleapis/commit/3fde7ab75e8161d7fa66984dd1705b02a354a035 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/636957906cc7868065a50cef61f5e995a75ae3e6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjM2OTU3OTA2Y2M3ODY4MDY1YTUwY2VmNjFmNWU5OTVhNzVhZTNlNiJ9 fix!: temporarily removed language rules from Speech-to-Text V2 API BUILD.bazel file PiperOrigin-RevId: 475956674 Source-Link: https://togithub.com/googleapis/googleapis/commit/210422e82d7077829aa5270a9894fa667782182d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/43a371600cebdecaa8186f47920a9a471182dd5b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNhMzcxNjAwY2ViZGVjYWE4MTg2ZjQ3OTIwYTlhNDcxMTgyZGQ1YiJ9 feat: added Speech-to-Text V2 API proto The next generation Speech-to-Text V2 API provides the same features clients are familiar with in the existing Speech-to-Text API, while modernizing and simplifying the API using API best practices, resourceful methods, and updated infrastructure. Although this proto is published, the service is not yet available. PiperOrigin-RevId: 474926510 Source-Link: https://togithub.com/googleapis/googleapis/commit/bb4d7f49441884fdfffa2d7552254d8540a597e2 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/9ecdb75038b10cfe4685d8a301e2abf8e4dfaa48 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWVjZGI3NTAzOGIxMGNmZTQ2ODVkOGEzMDFlMmFiZjhlNGRmYWE0OCJ9

… to v4.0.7 (#956) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dataproc](https://togithub.com/googleapis/java-dataproc) | `4.0.6` -> `4.0.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.7/compatibility-slim/4.0.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataproc/4.0.7/confidence-slim/4.0.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobuf](https://developers.google.com/protocol-buffers/) | `==3.19.5` -> `==3.20.2` | [![age](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/compatibility-slim/3.19.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/confidence-slim/3.19.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28) ### Dependencies * Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09)) * Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904)) * Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61)) * Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f)) * Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f)) * Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1)) * Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe)) * Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa)) * Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e)) * Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3)) * Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2)) * Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1)) * Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579)) * Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8)) * Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7)) * Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa)) * Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf)) * Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6)) * Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535)) * Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46)) * Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3)) * Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9)) * Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…o v2.1.2 (#956)

…a to 2.16.0 (#956) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 446250659 Source-Link: googleapis/googleapis@dc4ef31 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5fdda4ddfbab87998e77e4a453e0ff87986d2db8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWZkZGE0ZGRmYmFiODc5OThlNzdlNGE0NTNlMGZmODc5ODZkMmRiOCJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

shinfan added 3 commits April 21, 2016 18:03

Update gcloud pubsub.

f9e939f

- compatible with GAX 0.0.11 - better documentation

Merge branch 'pubsub-alpha' of github.com:GoogleCloudPlatform/gcloud-…

1c9065e

…java into pubsub-alpha

Add custom port support to LcoalPubsubHelper

ddd117d

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2016

mziccard reviewed Apr 25, 2016
View reviewed changes

gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubsubHelper.java

private final LocalServiceHelper serviceHelper;

private final List<String> gcloudCommand;

private final URL emulatorUrl;

This comment was marked as spam.

Sign in to view

shinfan force-pushed the pubsub-alpha branch from 8233321 to f5d4df7 Compare April 25, 2016 19:46

mziccard reviewed Apr 25, 2016
View reviewed changes

Update

2637346

shinfan force-pushed the pubsub-alpha branch from f5d4df7 to 2637346 Compare April 25, 2016 20:05

aozarov reviewed Apr 25, 2016
View reviewed changes

mziccard merged commit 8e914de into googleapis:pubsub-alpha Apr 25, 2016

mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016

Add custom port support to LocalPubsubHelper (googleapis#956)

7c56fc2

release-please bot mentioned this pull request Aug 24, 2022

chore: release monorepo_script_output #8199

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.api-client:google-api-client-bom t…

9d69e7b

…o v2.1.2 (#956)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom port support to LocalPubsubHelper#956

Add custom port support to LocalPubsubHelper#956
mziccard merged 4 commits intogoogleapis:pubsub-alphafrom
shinfan:pubsub-alpha

shinfan commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

shinfan commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

mziccard commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

shinfan commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

shinfan commented Apr 25, 2016

Uh oh!

coveralls commented Apr 25, 2016

Uh oh!

mziccard commented Apr 25, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants