Conversation
Contributor
|
LGTM @tseaver Any comments? |
Contributor
|
LGTM |
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
) Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Currently the system tests were failing with a message "TypeError: 'async_generator' object is not callable". This is because newer versions of pytest_asyncio uses "strict" mode by default which does not automatically convert fixtures to async fixtures in async test cases. This became an issue as of pytest_asyncio version 19. The solution is to either switch the mode to "auto" in the nox commandline or to mark the async fixtures as async fixtures. I've opted for the second to avoid making this hard to discover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gcloud is adopting a Code of Conduct. This PR adds the Code of Conduct that was agreed upon in GoogleCloudPlatform/gcloud-common#23.