Adding optional content type argument to generate signed URI method · Pull Request #1447 · googleapis/google-cloud-python

ghost · 2016-02-12T04:37:07Z

Fix for #1429. Using default content type as application/octet-stream.

ghost · 2016-02-12T04:52:40Z

Appveyor build failing is covered on #1434.

gcloud/storage/blob.py

-                            response_type=None, response_disposition=None,
-                            generation=None):
+    def generate_signed_url(self, expiration, method='GET', client=None,
+                            content_type="application/octet-stream",


googlebot · 2016-02-13T06:31:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

ghost · 2016-02-13T06:36:39Z

@googlebot Check CLA again, please.

gcloud/storage/blob.py

-                            client=None, credentials=None,
-                            response_type=None, response_disposition=None,
-                            generation=None):
+                            content_type='application/octet-stream',


googlebot · 2016-02-13T09:50:05Z

CLAs look good, thanks!

tseaver · 2016-02-15T18:52:19Z

@cyluss can you please add a unit test to test_blob which exercises the explicit content_type argument, and asserts that it is passed through?

ghost · 2016-02-16T01:30:11Z

@tseaver Here you are. I appreciate for your feedback.

tseaver · 2016-02-16T01:50:35Z

LGTM.

@dhermes do I recall correctly that you meant to be turning off Appveyor for PRs?

dhermes · 2016-02-16T01:52:11Z

@tseaver I have set "Branches to build: Only branches specified below" to master, and it doesn't seem to matter.

- Testing with plain name (+2 squashed commits) Squashed commits: [d3ffb14] Keep code DRY [73c285c] Adding test that covers explicit content type argument

Adding optional content type argument to generate signed URI method

tseaver · 2016-02-17T13:42:37Z

Thanks very much, @cyluss!

ghost · 2016-02-17T13:52:15Z

@tseaver Your team gave me great experience. Thank you.

Without this fix the current compute engine tests are failing. Also 3 other APIs in googleapis would have failed if grpc+rest transport was enabled on them.

* fix: Ensure that refresh worker is pickle-able.

🤖 I have created a release *beep* *boop* --- ## [2.26.1](https://togithub.com/googleapis/google-auth-library-python/compare/v2.26.0...v2.26.1) (2024-01-03) ### Bug Fixes * Ensure that refresh worker is pickle-able. ([#1447](https://togithub.com/googleapis/google-auth-library-python/issues/1447)) ([421c184](https://togithub.com/googleapis/google-auth-library-python/commit/421c184ff4654024afe3e64754318a6be0cc96fc)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Adding optional content type argument to generate signed URI method

f7587e8

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2016

dhermes reviewed Feb 12, 2016
View reviewed changes

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 13, 2016

Reordering argument

e7b5082

dhermes reviewed Feb 13, 2016
View reviewed changes

gcloud/storage/blob.py Outdated

client=None, credentials=None,

response_type=None, response_disposition=None,

generation=None):

content_type='application/octet-stream',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Drop default content type

bae74e8

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 13, 2016

Adding test that covers explicit content type argument

791e1e7

- Testing with plain name (+2 squashed commits) Squashed commits: [d3ffb14] Keep code DRY [73c285c] Adding test that covers explicit content type argument

tseaver added a commit that referenced this pull request Feb 17, 2016

Merge pull request #1447 from cyluss/fix-1429

dc26221

Adding optional content type argument to generate signed URI method

tseaver merged commit dc26221 into googleapis:master Feb 17, 2016

ghost deleted the fix-1429 branch February 17, 2016 13:52

dhermes mentioned this pull request Feb 17, 2016

Upgrading version to 0.10.0. #1483

Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: unit test generation for boolean query prams (#1447)

d37aec5

Without this fix the current compute engine tests are failing. Also 3 other APIs in googleapis would have failed if grpc+rest transport was enabled on them.

parthea pushed a commit that referenced this pull request Nov 26, 2025

fix: Ensure that refresh worker is pickle-able. (#1447)

60dc1e1

* fix: Ensure that refresh worker is pickle-able.

Conversation

ghost commented Feb 12, 2016

Uh oh!

ghost commented Feb 12, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Feb 13, 2016

Uh oh!

ghost commented Feb 13, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Feb 13, 2016

Uh oh!

tseaver commented Feb 15, 2016

Uh oh!

ghost commented Feb 16, 2016

Uh oh!

tseaver commented Feb 16, 2016

Uh oh!

dhermes commented Feb 16, 2016

Uh oh!

tseaver commented Feb 17, 2016

Uh oh!

ghost commented Feb 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants