Skip to content

chore(librarian): update gapic-generator to 1.30.3#15363

Merged
parthea merged 1 commit intomainfrom
parthea-patch-9
Jan 13, 2026
Merged

chore(librarian): update gapic-generator to 1.30.3#15363
parthea merged 1 commit intomainfrom
parthea-patch-9

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 13, 2026

Mypy checks are currently failing on generated outputs, because the google-auth library recently added some stricter type annotations

For example, see the mypy failure here in python-datastore

@parthea parthea requested review from a team as code owners January 13, 2026 16:27
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 13, 2026

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical mypy check failures that emerged from recent updates to the google-auth library's type annotations. By upgrading the gapic-generator dependency, the project incorporates a necessary fix, ensuring that generated outputs pass static type analysis and maintain code quality standards.

Highlights

  • Dependency Update: The gapic-generator dependency has been updated from version 1.30.2 to 1.30.3 in the .generator/requirements.in file.
  • Mypy Fix: This update specifically addresses and fixes mypy check failures that were occurring due to stricter type annotations recently introduced in the google-auth library. The fix is tracked in gapic-generator-python pull request Speech Python 3.5 encoding content - 'not JSON serializable' #2520.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator dependency from version 1.30.2 to 1.30.3. This is a necessary change to address mypy check failures resulting from stricter type annotations in the google-auth library. The change is correct and the updated comment in the requirements file provides useful context. The change looks good.

@parthea parthea merged commit 5070bdb into main Jan 13, 2026
26 checks passed
@parthea parthea deleted the parthea-patch-9 branch January 13, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @gkevinzheng