-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian update image pull request: 20260205T214646Z #15532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Python librarian generator image. Alongside this, it introduces a widespread refactoring of protobuf import statements to a more explicit Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from the librarian tool, refreshing the generator image and regenerating client libraries. The changes are mostly stylistic, such as updating import formats and serialization methods, which is fine. The identified recurring issue across many of the generated rest.py transport files regarding the use of bare except: clauses remains, as it is a valid concern not covered by the provided rules. All comments highlighting this issue have been retained with their original suggestions. This might be an issue in the generator itself that needs to be addressed.
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
| request_payload = type(request).to_json(request) | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare except: clause is discouraged as it catches all exceptions, including system-exiting ones like SystemExit or KeyboardInterrupt. It's better to catch a more specific exception, like Exception, to avoid unintentionally suppressing important errors.
| request_payload = type(request).to_json(request) | |
| except: | |
| request_payload = type(request).to_json(request) | |
| except Exception: |
Re-generate `grafeas` following #15532 which mentions `Generation failed for grafeas`
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.0.0-20260210205451-43b900a12d48 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836 <details><summary>google-cloud-artifact-registry: v1.20.0</summary> ## [v1.20.0](google-cloud-artifact-registry-v1.19.0...google-cloud-artifact-registry-v1.20.0) (2026-02-12) ### Features * add DIRSUM_SHA256 hash type (PiperOrigin-RevId: 865552557) ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-bigquery-storage: v2.36.1</summary> ## [v2.36.1](google-cloud-bigquery-storage-v2.36.0...google-cloud-bigquery-storage-v2.36.1) (2026-02-12) ### Bug Fixes * fix mypy (#15531) ([f2536ae](f2536ae3)) ### Documentation * Update BigQuery Storage Arrow samples batching logic (#14961) ([45d4cee](45d4cee9)) </details> <details><summary>google-cloud-confidentialcomputing: v0.8.0</summary> ## [v0.8.0](google-cloud-confidentialcomputing-v0.7.0...google-cloud-confidentialcomputing-v0.8.0) (2026-02-12) ### Features * add Nvidia Attestation proto message with its relevant fields and ConfidentialGke options (PiperOrigin-RevId: 866189208) ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-databasecenter: v0.5.0</summary> ## [v0.5.0](google-cloud-databasecenter-v0.4.0...google-cloud-databasecenter-v0.5.0) (2026-02-12) ### Features * Adding Method QueryIssues of Database Center API v1beta (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) ### Documentation * A comment for field `order_by` in message `.google.cloud.databasecenter.v1beta.AggregateFleetRequest` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for field `order_by` in message `.google.cloud.databasecenter.v1beta.QueryDatabaseResourceGroupsRequest` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for message `AggregateFleetResponse` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for field `filter` in message `.google.cloud.databasecenter.v1beta.AggregateFleetRequest` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for field `filter` in message `.google.cloud.databasecenter.v1beta.AggregateIssueStatsRequest` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for field `filter` in message `.google.cloud.databasecenter.v1beta.QueryDatabaseResourceGroupsRequest` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) * A comment for field `maintenance_version` in message `.google.cloud.databasecenter.v1beta.MaintenanceInfo` is changed (PiperOrigin-RevId: 868397264) ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-dataform: v0.9.0</summary> ## [v0.9.0](google-cloud-dataform-v0.8.0...google-cloud-dataform-v0.9.0) (2026-02-12) ### Features * Update GCP Client Libraries in v1beta1 to support Folders, TeamFolders, and other relevant APIs The v1beta1 API now includes support for Folders and TeamFolders, allowing users to organize repositories and files hierarchically and manage access controls. New Features: - Added TeamFolder resource and methods: CreateTeamFolder, GetTeamFolder, UpdateTeamFolder, DeleteTeamFolder QueryTeamFolderContents to list folder contents. SearchTeamFolders to search for TeamFolders. - Added Folder resource and methods: CreateFolder, GetFolder, UpdateFolder, DeleteFolder QueryFolderContents to list folder contents. Added MoveFolder to move Folders between TeamFolders, other Folders, or the user root folder. - Added MoveRepository to move Repositories between TeamFolders, Folders, or the user root folder. - Added QueryUserRootContents to list contents of a user&#39;s root folder. Repository resource now includes containing_folder and team_folder_name fields to indicate its location within the folder hierarchy. - IAM methods (GetIamPolicy, SetIamPolicy, TestIamPermissions) now support Folder and TeamFolder resources for access control management ([5371e8e](5371e8e9)) ### Documentation * A comment for field `force` in message `.google.cloud.dataform.v1beta1.DeleteRepositoryRequest` is changed PiperOrigin-RevId: 868182714 ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-dialogflow: v2.46.0</summary> ## [v2.46.0](google-cloud-dialogflow-v2.45.0...google-cloud-dialogflow-v2.46.0) (2026-02-12) ### Features * added a new field StreamingAnalyzeContentRequest.output_multiple_utterances (PiperOrigin-RevId: 862959083) ([a6b40b3](a6b40b31)) </details> <details><summary>google-cloud-discoveryengine: v0.17.0</summary> ## [v0.17.0](google-cloud-discoveryengine-v0.16.0...google-cloud-discoveryengine-v0.17.0) (2026-02-12) ### Features * add CrowdingSpec to SearchRequest to set crowding settings (PiperOrigin-RevId: 868345232) ([b483e92](b483e921)) * add Natural Language Query Understanding fields and messages to DiscoveryEngine request, response, and datastore messages (PiperOrigin-RevId: 868345232) ([b483e92](b483e921)) * add output-only field SemanticState to SearchResponse. (PiperOrigin-RevId: 868345232) ([b483e92](b483e921)) ### Documentation * other misc documentation updates Clients can specify Natural Language Query Understanding-related fields, as well as CrowdingSpec. These features are available in the V1 APIs. (PiperOrigin-RevId: 868345232) ([b483e92](b483e921)) * update documentation for search and data store NLQ features (PiperOrigin-RevId: 868345232) ([b483e92](b483e921)) </details> <details><summary>google-cloud-documentai: v3.10.0</summary> ## [v3.10.0](google-cloud-documentai-v3.9.0...google-cloud-documentai-v3.10.0) (2026-02-12) ### Features * A new field `document_prompt` is added to message `.google.cloud.documentai.v1beta3.DocumentSchema` (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * A new field `document_type` is added to message `.google.cloud.documentai.v1beta3.ImportDocumentsRequest` (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * A new field `revisions` is added to message `.google.cloud.documentai.v1beta3.Evaluation` (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * The method `ReviewDocument` in `.google.cloud.documentai.v1beta3.DocumentProcessorService` is deprecated (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * A new field `enable_table_split` is added to message `.google.cloud.documentai.v1beta3.OcrConfig.LayoutParsingParams` (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * Added new messages `Documents` and `RawDocuments` for inline document input (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) * The field `skip_human_review` in messages `.google.cloud.documentai.v1beta3.ProcessRequest` and `.google.cloud.documentai.v1beta3.BatchProcessRequest` is deprecated (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) ### Bug Fixes * Removed the `SpannerIndexingConfig` message and the `spanner_indexing_config` field from `.google.cloud.documentai.v1beta3.Dataset` BREAKING CHANGE: The `SpannerIndexingConfig` message and the `spanner_indexing_config` field within the `Dataset` message have been removed. Client code referencing these will need to stop referencing these in case of an error (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) ### Documentation * Updated comments for various fields and messages (PiperOrigin-RevId: 866382481) ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-gke-hub: v1.21.0</summary> ## [v1.21.0](google-cloud-gke-hub-v1.20.0...google-cloud-gke-hub-v1.21.0) (2026-02-12) ### Features * Add GKE Hub teams scope and RBAC GAPIC (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) ### Documentation * A comment for field `cancel_requested` in message `.google.cloud.gkehub.v1.OperationMetadata` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `state` in message `.google.cloud.gkehub.v1.CommonFeatureState` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for enum value `ENABLING` in enum `State` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for message `CommonFeatureState` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `state` in message `.google.cloud.gkehub.v1.Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `membership_states` in message `.google.cloud.gkehub.v1.Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for enum value `DISABLING` in enum `State` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `request_id` in message `.google.cloud.gkehub.v1.UpdateFeatureRequest` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `spec` in message `.google.cloud.gkehub.v1.Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for message `Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `request_id` in message `.google.cloud.gkehub.v1.CreateFeatureRequest` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for enum value `ACTIVE` in enum `State` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `membership_specs` in message `.google.cloud.gkehub.v1.Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for message `FeatureResourceState` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) * A comment for field `labels` in message `.google.cloud.gkehub.v1.Feature` is changed (PiperOrigin-RevId: 865111649) ([99a1284](99a1284f)) </details> <details><summary>google-cloud-storage-control: v1.10.0</summary> ## [v1.10.0](google-cloud-storage-control-v1.9.0...google-cloud-storage-control-v1.10.0) (2026-02-12) ### Features * add a DeleteFolderRecursive API definition (PiperOrigin-RevId: 866471251) ([5371e8e](5371e8e9)) </details> <details><summary>google-cloud-visionai: v0.4.0</summary> ## [v0.4.0](google-cloud-visionai-v0.3.0...google-cloud-visionai-v0.4.0) (2026-02-12) ### Bug Fixes * An existing default host `visionai.googleapis.com` is changed to `warehouse-visionai.googleapis.com` in service `Warehouse` (PiperOrigin-RevId: 866154811) ([5371e8e](5371e8e9)) ### Documentation * A comment for field `relevance` in message `.google.cloud.visionai.v1.SearchResultItem` is changed (PiperOrigin-RevId: 866154811) ([5371e8e](5371e8e9)) * A comment for field `page_size` in message `.google.cloud.visionai.v1.SearchIndexEndpointRequest` is changed (PiperOrigin-RevId: 866154811) ([5371e8e](5371e8e9)) </details> <details><summary>google-maps-solar: v0.4.0</summary> ## [v0.4.0](google-maps-solar-v0.3.0...google-maps-solar-v0.4.0) (2026-02-12) ### Documentation * Add satellite imagery to `rgb_url` description (PiperOrigin-RevId: 866492024) ([5371e8e](5371e8e9)) * Add pre-GA details for Experiments enum (PiperOrigin-RevId: 866492024) ([5371e8e](5371e8e9)) </details> <details><summary>Bulk Changes</summary> * chore: librarian update image pull request: 20260205T214646Z (#15532) ([3654fe7](3654fe76)) Libraries: google-cloud-artifact-registry,google-cloud-bigquery-storage,google-cloud-confidentialcomputing,google-cloud-databasecenter,google-cloud-dataform,google-cloud-dialogflow,google-cloud-discoveryengine,google-cloud-documentai,google-cloud-gke-hub,google-cloud-storage-control,google-cloud-visionai,google-maps-solar * chore: sort repo metadata by key (#15529) ([7da7768](7da7768c)) Libraries: google-cloud-artifact-registry,google-cloud-bigquery-storage,google-cloud-confidentialcomputing,google-cloud-databasecenter,google-cloud-dataform,google-cloud-dialogflow,google-cloud-discoveryengine,google-cloud-documentai,google-cloud-gke-hub,google-cloud-storage-control,google-cloud-visionai,google-maps-solar * chore: librarian update image pull request: 20260123T001116Z (#15481) ([871cdee](871cdeeb)) Libraries: google-cloud-artifact-registry,google-cloud-bigquery-storage,google-cloud-confidentialcomputing,google-cloud-databasecenter,google-cloud-dataform,google-cloud-dialogflow,google-cloud-discoveryengine,google-cloud-gke-hub,google-cloud-storage-control,google-cloud-visionai,google-maps-solar </details>
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836
Generation failed for