Fix 'Sink.from_api_repr'.#1825
Merged
tseaver merged 1 commit intogoogleapis:masterfrom May 26, 2016
tseaver:1817-logging-fix-sink-from_api_repr
Merged
Fix 'Sink.from_api_repr'.#1825tseaver merged 1 commit intogoogleapis:masterfrom tseaver:1817-logging-fix-sink-from_api_repr
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:1817-logging-fix-sink-from_api_repr
Conversation
Resource's 'name' field is not a path (like metric). Also, drop the no-longer-needed name-from-path regexps/helpers for metric and sink. Add a system test for 'Client.list_sinks' which exercises 'Sink.from_api_repr' against real resource data. Closes #1817.
Contributor
|
Pretty simple to review, no comments from me but I want @waprin to have a look before I sign off. |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource's
namefield is not a path (like metric).Also, drop the no-longer-needed name-from-path regexps/helpers for metric and sink.
Add a system test for
Client.list_sinkswhich exercisesSink.from_api_repragainst real resource data.Closes #1817.