Make table snippets testable#1833
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Jul 13, 2016
tseaver:bigquery-testable_table_snippets
Merged
Make table snippets testable#1833tseaver merged 1 commit intogoogleapis:masterfrom tseaver:bigquery-testable_table_snippets
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:bigquery-testable_table_snippets
Conversation
Contributor
Author
|
Rebased after merging #1832 to |
Contributor
|
@tseaver I guess it needs to be rebased again :( |
Contributor
Author
|
@daspecster Funny, that -- this PR already fixed that example (by making it testable). |
Contributor
|
LGTM We should close #1980 when this merges. |
This was referenced Aug 3, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1832 as a base.Toward a real fix for #1786 and related issues (usage docs out-of-sync with API surface).