Add speech async JSON/REST system tests. by daspecster · Pull Request #2648 · googleapis/google-cloud-python

daspecster · 2016-10-31T14:12:05Z

This adds JSON/REST system tests for speech's async_recognize() method.

system_tests/speech.py


+    def _make_async_request(self, content=None, source_uri=None,
+                            max_alternatives=None):
+        client = speech.Client(use_gax=False)


system_tests/speech.py

+                                        profanity_filter=True,
+                                        speech_context=['Google', 'cloud'])
+
+        return result


system_tests/speech.py

+        import time
+        with open(AUDIO_FILE, 'rb') as file_obj:
+            operation = self._make_async_request(content=file_obj.read(),
+                                                 max_alternatives=2)


system_tests/speech.py

        self._check_best_results(result)
+
+    def test_async_recognize_local_file(self):
+        import time


system_tests/speech.py

+        while retry_count > 0 and not operation.complete:
+            retry_count -= 1
+            time.sleep(10)
+            operation.poll()


system_tests/speech.py

+        source_uri = 'gs://%s/%s' % (bucket_name, blob_name)
+        operation = self._make_async_request(source_uri=source_uri,
+                                             max_alternatives=2)
+        retry_count = 100


system_tests/speech.py

+        retry_count = 100
+        while retry_count > 0 and not operation.complete:
+            retry_count -= 1
+            time.sleep(10)


system_tests/speech.py

+        results = operation.results
+        self.assertIsInstance(results[0], Transcript)
+        self.assertEqual(results[0].transcript, 'hello ' + self.ASSERT_TEXT)
+        self.assertGreater(results[0].confidence, 0.90)


system_tests/speech.py

+    """
+
+    def _operation_complete(result):
+        return result


system_tests/speech.py

    def test_async_recognize_local_file(self):
-        import time
+        if Config.USE_GAX:
+            self.skipTest('async_recognize gRPC not yet implemented.')


dhermes · 2016-10-31T17:01:05Z

LGTM (assuming you are tracking those skipTest usages)

system_tests/speech.py

+    :rtype: bool
+    :returns: Boolean indicating if the operation is complete.
+    """
+


dhermes

LGTM provided you are tracking skipTest

daspecster · 2016-10-31T17:04:47Z

Ok I'm squashing now. Thanks!

…est-system-tests Add speech async JSON/REST system tests.

daspecster added testing api: speech Issues related to the Speech-to-Text API. labels Oct 31, 2016

daspecster assigned tseaver and dhermes Oct 31, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016

daspecster mentioned this pull request Oct 31, 2016

Tracking Speech API development. #2522

Closed

14 tasks

dhermes reviewed Oct 31, 2016

View reviewed changes

daspecster mentioned this pull request Oct 31, 2016

Add speech sync JSON/REST system tests. #2649

Closed

dhermes reviewed Oct 31, 2016

View reviewed changes

system_tests/speech.py Outdated

"""

def _operation_complete(result):

return result

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 31, 2016

View reviewed changes

system_tests/speech.py

def test_async_recognize_local_file(self):

import time

if Config.USE_GAX:

self.skipTest('async_recognize gRPC not yet implemented.')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 31, 2016

View reviewed changes

system_tests/speech.py Outdated

:rtype: bool

:returns: Boolean indicating if the operation is complete.

"""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes approved these changes Oct 31, 2016

View reviewed changes

Add async JSON/REST system tests.

80e4143

daspecster force-pushed the add-speech-async-rest-system-tests branch from b79b1ee to 80e4143 Compare October 31, 2016 17:05

daspecster merged commit 56fb77c into googleapis:master Oct 31, 2016

daspecster deleted the add-speech-async-rest-system-tests branch October 31, 2016 17:15

daspecster mentioned this pull request Nov 1, 2016

Discussing adding separate system tests for REST and gRPC. #2658

Closed

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Merge pull request googleapis#2648 from daspecster/add-speech-async-r…

8949c24

…est-system-tests Add speech async JSON/REST system tests.

theacodes unassigned dhermes Sep 28, 2018

Conversation

daspecster commented Oct 31, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 31, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

daspecster commented Oct 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants