Add filename parameter to client image proxy.#2792
Merged
daspecster merged 1 commit intogoogleapis:masterfrom Dec 2, 2016
Merged
Add filename parameter to client image proxy.#2792daspecster merged 1 commit intogoogleapis:masterfrom
daspecster merged 1 commit intogoogleapis:masterfrom
Conversation
10 tasks
tseaver
suggested changes
Dec 1, 2016
Contributor
tseaver
left a comment
There was a problem hiding this comment.
LGTM except for the testcase split.
| file_image = client.image(filename='my_image.jpg') | ||
| m.assert_called_once_with('my_image.jpg', 'rb') | ||
| self.assertIsInstance(file_image, Image) | ||
| self.assertEqual(file_image.content, B64_IMAGE_CONTENT) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
I got a 👍 from @tseaver on the change so I'm going to merge this. |
20f0f7f to
7aec5b0
Compare
Contributor
Author
|
Squashed and cancelled travis. Once CircleCI goes green I'll merge. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…e-to-client-image Add filename parameter to client image proxy.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…t-image Add filename parameter to client image proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2753
Essentially I forgot to add this to the
client.image()proxy.