Making Connection()-s act as proxies for data stored in Client()-s#2970
Merged
dhermes merged 16 commits intogoogleapis:masterfrom Jan 30, 2017
Merged
Making Connection()-s act as proxies for data stored in Client()-s#2970dhermes merged 16 commits intogoogleapis:masterfrom
dhermes merged 16 commits intogoogleapis:masterfrom
Conversation
…client. Still leaving proxy properties on Connection to point to the http and credentials objects owned by the client.
Contributor
Contributor
Author
|
@lukesneeringer @tseaver PTAL. This is (most likely) blocking a |
lukesneeringer
approved these changes
Jan 30, 2017
Contributor
lukesneeringer
left a comment
There was a problem hiding this comment.
This looks fine to me (while acknowledging my limitations in reading a huge PR).
Contributor
|
LGTM. @lukesneeringer Are you from Texas? That avatar image looks like the "Come and Take It!" flag. |
Contributor
|
Yeah; I just moved to California in December after living in Texas for most of the last 3.5 decades. :-) (I also had a six month stint in Virginia.) |
Contributor
|
We've been in Virginia for the last 17 years, but I'm still a Texan (I taught Texas history to seventh graders long ago in a galaxy far away). |
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Making Connection()-s act as proxies for data stored in Client()-s
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Making Connection()-s act as proxies for data stored in Client()-s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a re-factoring effort to remove / reduce the role of
Connectionclasses (since they are outdated): #2606I ran the system tests and
speechis failing but I think it's unrelated to this? Also, the umbrella coverage is failing, so I sent #2969 to fix (also unrelated to this PR).