Skip to content

Update speech usage examples.#3206

Merged
lukesneeringer merged 3 commits intogoogleapis:masterfrom
daspecster:update-speech-examples-for-beta
Mar 30, 2017
Merged

Update speech usage examples.#3206
lukesneeringer merged 3 commits intogoogleapis:masterfrom
daspecster:update-speech-examples-for-beta

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Mar 24, 2017

@daspecster daspecster added api: speech Issues related to the Speech-to-Text API. docs labels Mar 24, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2017
@daspecster daspecster mentioned this pull request Mar 24, 2017
Closed
24 tasks
dhermes
dhermes reviewed Mar 24, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a great opportunity to other put this in a speech_snippets.py file or follow the template of datastore and just test as doctests?

docs/speech-usage.rst Outdated
... speech.Encoding.FLAC, 16000,
... source_uri='gs://my-bucket/recording.flac', language_code='en-GB',
... max_alternatives=2)
>>> results = sample.sync_recognize(language_code='en-GB', max_alternatives=2)

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

daspecster commented Mar 24, 2017

@dhermes yeah I think it would be. @lukesneeringer sounded like I should just run through these manually for now but I'm game either way.

@lukesneeringer WDYT?

@dhermes
Copy link
Contributor

dhermes commented Mar 24, 2017

These "hand-crafted" code snippets will always be vulernable to bit-rot if we don't have a way to test them.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 24, 2017

Speech is not a GA candidate, so if you are done checking off the GA requirements, feel free to take a more involved pass and make doctests.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 24, 2017

To be clear, though, please make sure everything is pristine on the GA libraries first.

@daspecster
Copy link
Contributor Author

daspecster commented Mar 24, 2017 •
edited
Loading

@lukesneeringer @dhermes continue back into the original issue?
#3172 (comment)

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 27, 2017

Yes.

@daspecster
Copy link
Contributor Author

daspecster commented Mar 28, 2017 •
edited
Loading

@lukesneeringer / @dhermes is this good to merge?

@lukesneeringer lukesneeringer merged commit 2a0ba64 into googleapis:master Mar 30, 2017
@daspecster daspecster deleted the update-speech-examples-for-beta branch March 30, 2017 15:22
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster @lukesneeringer
Update speech usage examples. (googleapis#3206)
e415799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daspecster @dhermes @lukesneeringer @tseaver @googlebot