Skip to content

Fix untested logging snippet examples.#3219

Merged
lukesneeringer merged 1 commit intogoogleapis:masterfrom
daspecster:update-logging-examples
Mar 30, 2017
Merged

Fix untested logging snippet examples.#3219
lukesneeringer merged 1 commit intogoogleapis:masterfrom
daspecster:update-logging-examples

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Mar 28, 2017

These snippets aren't covered in logging_snippets.py and they had a couple small syntax issues.

@daspecster daspecster added api: logging Issues related to the Cloud Logging API. docs labels Mar 28, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
@daspecster daspecster mentioned this pull request Mar 28, 2017
Closed
24 tasks
dhermes
dhermes reviewed Mar 28, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix untested snippet examples." doesn't keep them from being untested and breaking under future changes (or future changes in the library).

Do you have a plan to stabilize them further?

docs/logging-stdlib-usage.rst
.. code-block:: python

>>> setup_logging(handler, excluded_loggers=('werkzeug',)))
>>> setup_logging(handler, excluded_loggers=('werkzeug',))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/google/cloud/logging/handlers/handlers.py
client = google.cloud.logging.Client()
handler = CloudLoggingHandler(client)
google.cloud.logging.setup_logging(handler)
google.cloud.logging.handlers.setup_logging(handler)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 28, 2017

Do you have a plan to stabilize them further?

I would love that to be a project soon, but it is not the project I gave him. :-)

@daspecster daspecster changed the title Fix untested snippet examples. Fix untested logging snippet examples. Mar 28, 2017
@lukesneeringer lukesneeringer merged commit e2921c7 into googleapis:master Mar 30, 2017
@daspecster daspecster deleted the update-logging-examples branch March 30, 2017 15:14
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster @lukesneeringer
Fix untested snippet examples. (googleapis#3219)
00ee0fa
parthea pushed a commit that referenced this pull request Nov 24, 2025
@daspecster @lukesneeringer
Fix untested snippet examples. (#3219)
9e5c33e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@lukesneeringer lukesneeringer lukesneeringer left review comments

@dhermes dhermes dhermes left review comments

@waprin waprin waprin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daspecster @lukesneeringer @dhermes @waprin @tseaver @googlebot