Renaming http argument(s) as _http.#3235
Merged
lukesneeringer merged 6 commits intogoogleapis:masterfrom Mar 30, 2017
Merged
Conversation
Done via several commands from the CLI: $ git grep -l use_gax | xargs sed -i s/use_gax/_use_grpc/g $ git grep -l __use_grpc | xargs sed -i s/__use_grpc/_use_grpc/g $ git grep -l USE_GAX | xargs sed -i s/USE_GAX/USE_GRPC/g $ git grep -l HAVE_GAX | xargs sed -i s/HAVE_GAX/HAVE_GRPC/g $ git grep -l DISABLE_GAX | xargs sed -i s/DISABLE_GAX/DISABLE_GRPC/g as well as some manual edits for indent / line length (only did this around `:param _use_grpc:`).
Contributor
Author
|
@lukesneeringer 👍 on your commit |
Contributor
Author
|
@lukesneeringer We all good here? |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 30, 2017
Issue caused by two unrelated PRs merging in close proximity: googleapis#3235 and googleapis#3230.
lukesneeringer
pushed a commit
that referenced
this pull request
Mar 30, 2017
|
@dhermes I just started getting errors that might have to do with this change. It's happening in my dataproc jobs, but I was able to reproduce the error in a fresh VM instance: $ sudo easy_install pip
$ sudo pip install google-cloud google-cloud-storage
$ python -c "from google.cloud import storage; storage.Client(project='<project>')"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/google/cloud/storage/client.py", line 59, in
__init__
_http=_http)
TypeError: __init__() got an unexpected keyword argument '_http'I'm going to poke around the code in the VM to see what's up. |
Contributor
Author
|
I'd guess you have versions of |
Contributor
Author
|
Thanks for letting us know though! |
|
I ran |
Contributor
|
@lukesneeringer @dhermes Is there background as to why the http object was made private? I haven't looked at this PR in detail yet, but has this change been made across all current clients? Future clients will adhere to the same contract? |
Contributor
Author
|
@supertom Yes this was made across all clients. It was done because we will be changing the underlying HTTP transport implementation, so making it part of the public interface was a bad idea (i.e. since we'd be breaking that interface). |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Issue caused by two unrelated PRs merging in close proximity: googleapis#3235 and googleapis#3230.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will also shortly be sending a commit to this PR which renames
use_gaxand_use_grpc.grep-ing forhttpandhttp=was pretty ad-hoc, so I'm not sure if there are lingering things needing to be changed (e.g. docs which refer tohttpinstead of_http)Note in the commit about
use_gaxthe following commands were used: