Add system test for Database convenience methods: by tseaver · Pull Request #3385 · googleapis/google-cloud-python

tseaver · 2017-05-08T22:00:28Z

batch
snapshot
read
run_with_transaction
execute_sql

Closes #3015.

dhermes

Looks mostly fine

spanner/tests/system.py

        self.assertEqual(len(temp_db.ddl_statements), len(DDL_STATEMENTS))

+    def test_db_batch_insert_then_db_snapshot_read_and_db_read(self):
+        from google.cloud.spanner import KeySet


spanner/tests/system.py


+    def test_db_batch_insert_then_db_snapshot_read_and_db_read(self):
+        from google.cloud.spanner import KeySet
+        keyset = KeySet(all_=True)


spanner/tests/system.py

+        retry(self._db.reload)()
+
+        with self._db.batch() as batch:
+            batch.delete(self.TABLE, keyset)


spanner/tests/system.py

+            batch.insert(self.TABLE, self.COLUMNS, self.ROW_DATA)
+
+        with self._db.snapshot(read_timestamp=batch.committed) as snapshot:
+            from_snap = list(snapshot.read( self.TABLE, self.COLUMNS, keyset))


spanner/tests/system.py

+        with self._db.batch() as batch:
+            batch.delete(self.TABLE, keyset)
+
+        def _unit_of_work(transaction, test):


tseaver · 2017-05-08T22:34:36Z

Should I follow suit and push the updated branch to the origin to get a build with system tests? We could close this PR and re-open there.

- batch - snapshot - read - run_with_transaction - execute_sql Closes #3015.

dhermes · 2017-05-08T23:18:25Z

@tseaver Yes I think you should push this branch to the GCP origin to get system tests running. You don't need to close this PR though, the tests will "just work" (i.e. be associated here).

tseaver · 2017-05-08T23:40:15Z

Pushed to upstream.

tseaver · 2017-05-09T19:58:35Z

@dhermes New system tests pass on CI. Any further issues?

dhermes · 2017-05-09T20:01:50Z

LGTM

…on-docs-samples#3385) * video: use flaky on flaky timeouts * Update beta_snippets_test.py * remove api result check * Update beta_snippets_test.py

tseaver added api: spanner Issues related to the Spanner API. release blocking Required feature/issue must be fixed prior to next release. testing labels May 8, 2017

tseaver requested review from dhermes and lukesneeringer May 8, 2017 22:00

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2017

dhermes reviewed May 8, 2017

View reviewed changes

Add system test for Database convenience methods:

036dd41

- batch - snapshot - read - run_with_transaction - execute_sql Closes #3015.

tseaver merged commit 19315e0 into googleapis:master May 9, 2017

tseaver deleted the 3015-spanner-convnience_wrapper_systests branch May 9, 2017 20:05

Conversation

tseaver commented May 8, 2017

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented May 8, 2017

Uh oh!

dhermes commented May 8, 2017

Uh oh!

tseaver commented May 8, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

dhermes commented May 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants