Skip to content

Switched to google-resumable-media in BigQuery.#3555

Merged
dhermes merged 10 commits intogoogleapis:masterfrom
dhermes:bigquery-remove-streaming
Jul 21, 2017
Merged

Switched to google-resumable-media in BigQuery.#3555
dhermes merged 10 commits intogoogleapis:masterfrom
dhermes:bigquery-remove-streaming

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 27, 2017 •
edited
Loading

@jonparrott Asked that I make a "do not merge" PR out of this, as a placeholder for the work remaining in #1998.

When I wrote this code (May 10th), the system tests all passed without issue (THAT WAS NOT TRUE WHEN I WROTE IT), but the unit tests are currently very broken by this change.

I am very much intentionally leaving the "Allow edits from maintainers" box checked, so anyone is free to fix the unit tests 😀

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. hygiene do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 27, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2017
@dhermes dhermes mentioned this pull request Jun 28, 2017
Closed
@dhermes dhermes mentioned this pull request Jul 13, 2017
Closed
@theacodes theacodes force-pushed the bigquery-remove-streaming branch from a97c930 to aa7999f Compare July 20, 2017 00:21
@theacodes theacodes added DevEx and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 20, 2017
@dhermes dhermes force-pushed the bigquery-remove-streaming branch from cc51bc0 to 2c45d9b Compare July 20, 2017 18:41
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2017 •
edited
Loading

OK after some work last night by @jonparrott and by me this AM, the unit tests are passing at 100%.

I'm fairly certain there will be a system test breakage though. I seem to recall the getting the size from the final 200 response of a finished resumable upload is "impossible" with the BigQuery API. (The real story: I assumed all APIs would return size because Storage did, it may have been a bad assumption.)

@dhermes dhermes mentioned this pull request Jul 20, 2017
Merged
@dhermes dhermes force-pushed the bigquery-remove-streaming branch from 2c45d9b to 2ae7cf3 Compare July 21, 2017 03:17
@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

w00t! I confirmed the system tests pass locally:

$ nox -s "system_tests(python_version='2.7')"
nox > Running session system_tests(python_version='2.7')
nox > virtualenv .../bigquery/.nox/sys-2-7 -p python2.7
nox > chdir .../bigquery
nox > pip install --upgrade mock pytest ../core
nox > pip install --upgrade ../storage ../test_utils
nox > pip install --upgrade .
nox > py.test --quiet tests/system.py
.........................
25 passed in 163.06 seconds
nox > Session system_tests(python_version='2.7') successful. :)
$
$
$ nox -s "system_tests(python_version='3.6')"
nox > Running session system_tests(python_version='3.6')
nox > virtualenv .../bigquery/.nox/sys-3-6 -p python3.6
nox > chdir .../bigquery
nox > pip install --upgrade mock pytest ../core
nox > pip install --upgrade ../storage ../test_utils
nox > pip install --upgrade .
nox > py.test --quiet tests/system.py
.........................
25 passed in 155.69 seconds
nox > Session system_tests(python_version='3.6') successful. :)

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2017

OK CircleCI is green. Let's merge?!?

@dhermes dhermes merged commit c5ccca1 into googleapis:master Jul 21, 2017
@dhermes dhermes deleted the bigquery-remove-streaming branch July 21, 2017 21:41
@dhermes dhermes mentioned this pull request Jul 21, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@dhermes @landrito
Switched to google-resumable-media in BigQuery. (googleapis#3555)
e3a765e 
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Switched to google-resumable-media in BigQuery. (googleapis#3555)
2b83dfd 
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Switched to google-resumable-media in BigQuery. (googleapis#3555)
b6e4dae 
* Switched to google-resumable-media in BigQuery.
* Upgrading google-resumable-media dependency to 0.2.1.
@tswast tswast mentioned this pull request Nov 18, 2021
Open
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
[kms] fix: use unique ids for test [(#3563)](GoogleCloudPlatform/pyth…
6a0ebf7 
…on-docs-samples#3563)

fixes #3554
fixes #3555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @theacodes @lukesneeringer @tseaver @googlebot