Address fourth part of 451: Make Key constructor easier to use by taking positional args. by dhermes · Pull Request #460 · googleapis/google-cloud-python

dhermes · 2014-12-23T02:29:51Z

Make Key constructor easier to use by taking positional args.

Addresses fourth part of #451.

NOTE: This has #459 as a diffbase.

coveralls · 2014-12-23T02:32:41Z

Coverage remained the same when pulling c17800d on dhermes:fix-451-part4 into b343acf on GoogleCloudPlatform:master.

tseaver · 2014-12-30T15:48:24Z

c17800d do we need to expose flat_path as a public method (it isn't tested explicitly, for instance). It looks as though we only use it in _make_parent (where we could just use the attribute).

Other than that, LGTM.

dhermes · 2014-12-30T17:38:32Z

RE: flat_path, I initially added it because I thought we'd need it for things like

>>> partial_key = Key('Foo', 1, 'Bar')
>>> new_path = partial_key.flath_path + (1000,)
>>> entity = Entity(*new_path)

This is no longer the goal, but ISTM the contents of flat_path will be much more useful to users than the contents of path as a list of dicts.

(Through some discussions in #336 and elsewhere it seems it's best to just have Entity.__init__ take a key as a positional arg, since we made the Key constructor easier to use already.)

coveralls · 2014-12-30T17:44:15Z

Coverage remained the same when pulling 03f5dd8 on dhermes:fix-451-part4 into 8cb41f6 on GoogleCloudPlatform:master.

dhermes · 2014-12-30T19:07:06Z

@tseaver I added 16760fb since your review because I realized we had false positives from things like

>>> datastore.key.Key('Foo', None, dataset_id='foo')
<Key[{'kind': 'Foo'}], dataset=foo>
>>> datastore.key.Key('Foo', None, 'Bar', 10, dataset_id='foo')
<Key[{'kind': 'Foo'}, {'kind': 'Bar', 'id': 10}], dataset=foo>

Addresses fourth part of googleapis#451.

tseaver · 2014-12-31T21:09:42Z

Ugh, the rebase ruins the commit hash in your comment.

If you don't think we need to pull the flat_path property, go ahead and merge.

coveralls · 2014-12-31T21:10:25Z

Coverage remained the same when pulling 676b20c on dhermes:fix-451-part4 into cfea8e9 on GoogleCloudPlatform:master.

Address fourth part of 451: Make Key constructor easier to use by taking positional args.

dhermes · 2014-12-31T21:12:13Z

@tseaver I agree having flat_path and path is confusing, I just am not sure which will be more useful going forward.

Co-authored-by: Nitsan Shai <nshai@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

* docs: clarified gcs_bucket field of the SecuritySettings message PiperOrigin-RevId: 477778532 Source-Link: googleapis/googleapis@22d2bda Source-Link: googleapis/googleapis-gen@821f121 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODIxZjEyMWYwMWMxNTBlNGRiZDBiZjlhNzkyYmMwNWMyY2VlYzFkMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: clarified gcs_bucket field of the SecuritySettings message PiperOrigin-RevId: 478035442 Source-Link: googleapis/googleapis@8cb255f Source-Link: googleapis/googleapis-gen@461eeeb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDYxZWVlYjc3MGMwMzk3YjVlZjgzOTJkMjQyOTk1M2YxMzkzZmY2NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@69fda12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(bazel): update protobuf to v3.21.3 chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: googleapis/googleapis-gen@6a4d9d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Nitsan Shai <nshai@google.com>

Source-Link: googleapis/synthtool@52aef91 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* test: alter tests, skip tests, to be compatible with emulator

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

dhermes mentioned this pull request Dec 23, 2014

Update Key API to be more user-friendly per design doc discussion #451

Closed

10 tasks

dhermes mentioned this pull request Dec 23, 2014

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Merged

dhermes force-pushed the fix-451-part4 branch from c17800d to 03f5dd8 Compare December 30, 2014 17:41

dhermes added 2 commits December 31, 2014 13:07

Make Key constructor easier to use by taking positional args.

c616671

Addresses fourth part of googleapis#451.

Fixing false positive key paths containing None.

676b20c

dhermes force-pushed the fix-451-part4 branch from 16760fb to 676b20c Compare December 31, 2014 21:08

dhermes added a commit that referenced this pull request Dec 31, 2014

Merge pull request #460 from dhermes/fix-451-part4

74e6c16

Address fourth part of 451: Make Key constructor easier to use by taking positional args.

dhermes merged commit 74e6c16 into googleapis:master Dec 31, 2014

dhermes deleted the fix-451-part4 branch December 31, 2014 21:12

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 6, 2023

samples: Code samples for Speech-to-Text V2 (#460)

d65d0d0

Co-authored-by: Nitsan Shai <nshai@google.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

samples: Code samples for Speech-to-Text V2 (#460)

47c2fb0

Co-authored-by: Nitsan Shai <nshai@google.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023

samples: Code samples for Speech-to-Text V2 (#460)

67e3151

Co-authored-by: Nitsan Shai <nshai@google.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.12.0 (#460)

1ade69a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-pubsub to v2.17.1 (#460)

ea54315

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-dataproc to v5.0.1 (#460)

2d90b04

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.10.0 (#460)

e5cdf0f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.2.0 (#460)

bfdd822

parthea pushed a commit that referenced this pull request Oct 22, 2023

samples: Code samples for Speech-to-Text V2 (#460)

95817e0

Co-authored-by: Nitsan Shai <nshai@google.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

test: alter tests, skip tests, to be compatible with emulator (#460)

9357e9d

* test: alter tests, skip tests, to be compatible with emulator

parthea added a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-storage to v1.44.0 (#460)

fa9ad53

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea added a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency google-cloud-storage to v1.44.0 (#460)

91d3109

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address fourth part of 451: Make Key constructor easier to use by taking positional args.#460

Address fourth part of 451: Make Key constructor easier to use by taking positional args.#460
dhermes merged 2 commits intogoogleapis:masterfrom
dhermes:fix-451-part4

dhermes commented Dec 23, 2014

Uh oh!

coveralls commented Dec 23, 2014

Uh oh!

tseaver commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

coveralls commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dhermes commented Dec 23, 2014

Uh oh!

coveralls commented Dec 23, 2014

Uh oh!

tseaver commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

coveralls commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants