Removing projection=full from Blob/Bucket PATCH requests.#758
Removing projection=full from Blob/Bucket PATCH requests.#758dhermes wants to merge 1 commit intogoogleapis:masterfrom
Conversation
|
I'm not aware of any issues, but is there a reason to specify noAcl? What if you're patching the ACL, don't you want to see the new one? Projection=full won't return the acl to you unless you have OWNER permission on the bucket/object anyway. |
|
RE: "is there a reason to specify noAcl" That is a discussion in flux. Currently ACL behavior is managed via dedicated objects instead of directly with the RE: "won't return the acl to you unless you have OWNER permission" I would wager that was the original author's concern. Thanks! |
|
The API docs say: |
|
@dhermes It has to do with the way that patch currently is implemented. I suspect that if you had custom ACLs on your bucket that if you patch with no_acl, you inadvertently reset your bucket ACL to project-private. |
|
I see.
|
Closing, based on "we do not need this" and also there is no possible way we would successfully wrangle a PR this old in even if we did. |
Source-Link: googleapis/synthtool@db94845 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a8a80fc6456e433df53fc2a0d72ca0345db0ddefb409f1b75b118dfd1babd952 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@db94845 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a8a80fc6456e433df53fc2a0d72ca0345db0ddefb409f1b75b118dfd1babd952 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([source](https://togithub.com/pallets/jinja)) | `==2.11.2` -> `==2.11.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pallets/jinja</summary> ### [`v2.11.3`](https://togithub.com/pallets/jinja/blob/master/CHANGES.rst#Version-2113) [Compare Source](https://togithub.com/pallets/jinja/compare/2.11.2...2.11.3) Released 2021-01-31 - Improve the speed of the `urlize` filter by reducing regex backtracking. Email matching requires a word character at the start of the domain part, and only word characters in the TLD. :pr:`1343` </details> --- ### Renovate configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).
There was a previous comment
I tested a little with this and it doesn't seem to be an issue.
@thobrla Can you confirm or deny any issues with
projection=full?