added optional content_type to bucket.upload_file#883
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
Contributor
|
Looks fine. Any reason why you don't just use the |
Author
|
not particularly, either works |
Contributor
|
I think we've even debated making Can you address the test failure: |
Author
|
hm.. the test passes for me |
Contributor
|
Thanks. You are running the tests locally via |
Author
|
yes, I am also using the code in production |
Contributor
|
Notice it's a test fixture |
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* chore(python): fix typo in README Source-Link: googleapis/synthtool@93e1685 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* chore(python): fix typo in README Source-Link: googleapis/synthtool@93e1685 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Small change to fix bug noticed in googleapis/python-dialogflow#288. The import was `from google.rpc import status_pb2` but code expected `gr_status`
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…mplates/python_library/.kokoro (#883) Source-Link: googleapis/synthtool@30bd01b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Feb 13, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-api-core: 2.29.0</summary> ## [2.29.0](googleapis/python-api-core@v2.28.1...v2.29.0) (2026-01-08) ### Features * make parse_version_to_tuple public (#864) ([c969186f](googleapis/python-api-core@c969186f)) * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f96](googleapis/python-api-core@f8bf6f96)) ### Bug Fixes * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e2](googleapis/python-api-core@628003e2)) * Log version check errors (#858) ([6493118c](googleapis/python-api-core@6493118c)) * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([93404080](googleapis/python-api-core@93404080)) * closes tailing streams in bidi classes. (#851) ([c97b3a00](googleapis/python-api-core@c97b3a00)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.