Skip to content

feat: add struct query parameters#223

Merged
stephaniewang526 merged 6 commits intogoogleapis:masterfrom
pmakani:bigquery-203
Mar 20, 2020
Merged

feat: add struct query parameters#223
stephaniewang526 merged 6 commits intogoogleapis:masterfrom
pmakani:bigquery-203

Conversation

@pmakani
Copy link
Contributor

@pmakani pmakani commented Mar 16, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #203

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #223 into master will increase coverage by 0.23%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
+ Coverage     77.36%   77.59%   +0.23%     
- Complexity     1116     1146      +30     
============================================
  Files            73       75       +2     
  Lines          5950     6074     +124     
  Branches        626      648      +22     
============================================
+ Hits           4603     4713     +110     
+ Misses         1019     1017       -2     
- Partials        328      344      +16
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java 81.77% <95.83%> (+9.04%) 60 <3> (+14) ⬆️
...om/google/cloud/bigquery/LoadJobConfiguration.java 87.02% <0%> (-2.62%) 52% <0%> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 93.75% <0%> (ø) 9% <0%> (?)
...gle/cloud/bigquery/MaterializedViewDefinition.java 70% <0%> (ø) 6% <0%> (?)
...ava/com/google/cloud/bigquery/TableDefinition.java 87.09% <0%> (+0.88%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee02cc1...a0600cf. Read the comment docs.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@stephaniewang526 stephaniewang526 mentioned this pull request Mar 19, 2020
Merged
@stephaniewang526 stephaniewang526 merged commit c1997dd into googleapis:master Mar 20, 2020
@pmakani pmakani deleted the bigquery-203 branch March 23, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for struct query parameters

5 participants

@pmakani @stephaniewang526 @googlebot @yoshi-kokoro @athakor