Skip to content

chore(main): release 0.167.1-SNAPSHOT#3593

Merged
Neenu1995 merged 1 commit intomainfrom
release-please--branches--main
Feb 28, 2022
Merged

chore(main): release 0.167.1-SNAPSHOT#3593
Neenu1995 merged 1 commit intomainfrom
release-please--branches--main

Conversation

@release-please
Copy link
Contributor

@release-please release-please bot commented Feb 7, 2022

🤖 I have created a release beep boop

Updating meta-information for bleeding-edge SNAPSHOT release.

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team February 7, 2022 23:07
@release-please release-please bot force-pushed the release-please--branches--main branch 23 times, most recently from d37d53d to 8ef7b23 Compare February 11, 2022 21:45
@release-please release-please bot force-pushed the release-please--branches--main branch 6 times, most recently from 2c7dee6 to dc0b35c Compare February 15, 2022 18:43
@release-please release-please bot force-pushed the release-please--branches--main branch 8 times, most recently from 9a02e0b to ca46af3 Compare February 18, 2022 19:22
@suztomo
Copy link
Member

suztomo commented Feb 18, 2022 •
edited
Loading

Convergence error on google-http-client

https://gist.github.com/suztomo/302835dfa07317d26d2f3277f7368b56

Warning:  
Dependency convergence error for com.google.http-client:google-http-client:jar:1.41.2:compile paths to dependency are:
+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-com.google.cloud:google-cloud-accessapproval:jar:2.1.10:compile
    +-com.google.http-client:google-http-client:jar:1.41.2:compile
and
...
+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-io.grafeas:grafeas:jar:2.2.0:compile
    +-com.google.http-client:google-http-client:jar:1.41.0:runtime

@suztomo
Copy link
Member

suztomo commented Feb 18, 2022 •
edited
Loading

A release from java-grafeas repository would resolve the ci / full-dependencies-convergence.

But it's blocked by Windows build failure: googleapis/java-grafeas#447 (comment) caused by b/217779626

@release-please release-please bot force-pushed the release-please--branches--main branch 3 times, most recently from ecefd24 to 2d1630f Compare February 22, 2022 15:03
@Neenu1995 Neenu1995 added the release-please:force-run To run release-please label Feb 22, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Feb 22, 2022
@release-please release-please bot force-pushed the release-please--branches--main branch 2 times, most recently from 8e52bbf to 8591e16 Compare February 22, 2022 18:25
@suztomo
Copy link
Member

suztomo commented Feb 22, 2022 •
edited
Loading

https://gist.github.com/suztomo/f8dae25b88da5fd8d011dab9bcadba31

GSON

google-cloud-logging is defining a newer version of GSON:

+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-com.google.cloud:google-cloud-logging:jar:3.6.4:compile
    +-com.google.code.gson:gson:jar:2.9.0:compile

-> googleapis/java-logging#878 (merged)

Checker-compat-qual

google-cloud-pubsublite is defining a newer version of checker-compat-qual:

+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-com.google.cloud:google-cloud-pubsublite:jar:1.4.11:compile
    +-org.checkerframework:checker-compat-qual:jar:2.5.3:compile

Google-api-services-storage

google-api-services-storage between com.google.cloud:google-cloud-notification and com.google.cloud:google-cloud-storage.

Dependency convergence error for com.google.apis:google-api-services-storage:jar:v1-rev20220210-1.32.1:compile paths to dependency are:
+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-com.google.cloud:google-cloud-notification:jar:0.122.21-beta:compile
    +-com.google.apis:google-api-services-storage:jar:v1-rev20220210-1.32.1:compile
and
+-com.google.cloud:full-convergence-check:pom:0.167.1-SNAPSHOT
  +-com.google.cloud:google-cloud-storage:jar:2.4.2:compile
    +-com.google.apis:google-api-services-storage:jar:v1-rev20211201-1.32.1:compile

Java-storage repository already merged googleapis/java-storage#1269 "deps: update dependency com.google.apis:google-api-services-storage to v1-rev20220210-1.32.1".

@suztomo suztomo mentioned this pull request Feb 22, 2022
Merged
4 tasks
@suztomo
Copy link
Member

suztomo commented Feb 22, 2022 •
edited
Loading

Why does google-cloud-pubsublite declare checker-compat-qual dependency? I don't see it in the effective pom.
https://gist.github.com/suztomo/b9acce2644b4c75286ae20cdda09ba0e

but the published POM https://search.maven.org/artifact/com.google.cloud/google-cloud-pubsublite/1.4.11/jar indeed has the dependency. It's very likely added by the flatten-maven-plugin.

Answer: it turned out that pubsublite's parent pom defines the independent version in it's root pom.xml:

<!-- Explicit override, remove when no longer needed.--> has been there since last September googleapis/java-pubsublite@a046b53 for version 3.17.0.

@suztomo suztomo mentioned this pull request Feb 22, 2022
Closed
@release-please release-please bot force-pushed the release-please--branches--main branch 2 times, most recently from 6e651d1 to fcf0c18 Compare February 28, 2022 15:22
@release-please release-please bot force-pushed the release-please--branches--main branch from fcf0c18 to 29a6d15 Compare February 28, 2022 15:25
@suztomo suztomo mentioned this pull request Feb 28, 2022
Merged
@Neenu1995
Copy link
Contributor

Neenu1995 commented Feb 28, 2022

Merging this to generate release PR.

@Neenu1995 Neenu1995 merged commit af810db into main Feb 28, 2022
@Neenu1995 Neenu1995 deleted the release-please--branches--main branch February 28, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @Neenu1995