Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

fix: reverting pull request #439 that broke CVSS.java#463

Merged
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:main
Feb 22, 2022
Merged

fix: reverting pull request #439 that broke CVSS.java#463
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:main

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Feb 18, 2022

Revert "fix: Modify the bazel.BUILD file by hand to include the compliance protos which are not autogenerated (#439).

This reverts commit f109202.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@suztomo
Revert "fix: Modify the bazel.BUILD file by hand to include the compl…
8e93c63 
…iance protos which are not autogenerated (googleapis#439)"

This reverts commit f109202.
@suztomo suztomo requested a review from a team February 18, 2022 19:56
@generated-files-bot
Copy link

generated-files-bot bot commented Feb 18, 2022

Warning: This pull request is touching the following templated files:

  • src/main/java/io/grafeas/v1/AliasContext.java
  • src/main/java/io/grafeas/v1/AliasContextOrBuilder.java
  • src/main/java/io/grafeas/v1/Architecture.java
  • src/main/java/io/grafeas/v1/Artifact.java
  • src/main/java/io/grafeas/v1/ArtifactOrBuilder.java
  • src/main/java/io/grafeas/v1/Attestation.java
  • src/main/java/io/grafeas/v1/AttestationNote.java
  • src/main/java/io/grafeas/v1/AttestationNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/AttestationOccurrence.java
  • src/main/java/io/grafeas/v1/AttestationOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/BatchCreateNotesRequest.java
  • src/main/java/io/grafeas/v1/BatchCreateNotesRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/BatchCreateNotesResponse.java
  • src/main/java/io/grafeas/v1/BatchCreateNotesResponseOrBuilder.java
  • src/main/java/io/grafeas/v1/BatchCreateOccurrencesRequest.java
  • src/main/java/io/grafeas/v1/BatchCreateOccurrencesRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/BatchCreateOccurrencesResponse.java
  • src/main/java/io/grafeas/v1/BatchCreateOccurrencesResponseOrBuilder.java
  • src/main/java/io/grafeas/v1/Build.java
  • src/main/java/io/grafeas/v1/BuildNote.java
  • src/main/java/io/grafeas/v1/BuildNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/BuildOccurrence.java
  • src/main/java/io/grafeas/v1/BuildOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/BuildProvenance.java
  • src/main/java/io/grafeas/v1/BuildProvenanceOrBuilder.java
  • src/main/java/io/grafeas/v1/BuilderConfig.java
  • src/main/java/io/grafeas/v1/BuilderConfigOrBuilder.java
  • src/main/java/io/grafeas/v1/CVSSv3.java
  • src/main/java/io/grafeas/v1/CVSSv3OrBuilder.java
  • src/main/java/io/grafeas/v1/CloudRepoSourceContext.java
  • src/main/java/io/grafeas/v1/CloudRepoSourceContextOrBuilder.java
  • src/main/java/io/grafeas/v1/Command.java
  • src/main/java/io/grafeas/v1/CommandOrBuilder.java
  • src/main/java/io/grafeas/v1/Common.java
  • src/main/java/io/grafeas/v1/Completeness.java
  • src/main/java/io/grafeas/v1/CompletenessOrBuilder.java
  • src/main/java/io/grafeas/v1/Compliance.java
  • src/main/java/io/grafeas/v1/ComplianceNote.java
  • src/main/java/io/grafeas/v1/ComplianceNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/ComplianceOccurrence.java
  • src/main/java/io/grafeas/v1/ComplianceOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/ComplianceVersion.java
  • src/main/java/io/grafeas/v1/ComplianceVersionOrBuilder.java
  • src/main/java/io/grafeas/v1/CreateNoteRequest.java
  • src/main/java/io/grafeas/v1/CreateNoteRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/CreateOccurrenceRequest.java
  • src/main/java/io/grafeas/v1/CreateOccurrenceRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/Cvss.java
  • src/main/java/io/grafeas/v1/DSSEAttestationNote.java
  • src/main/java/io/grafeas/v1/DSSEAttestationNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/DSSEAttestationOccurrence.java
  • src/main/java/io/grafeas/v1/DSSEAttestationOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/DeleteNoteRequest.java
  • src/main/java/io/grafeas/v1/DeleteNoteRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/DeleteOccurrenceRequest.java
  • src/main/java/io/grafeas/v1/DeleteOccurrenceRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/Deployment.java
  • src/main/java/io/grafeas/v1/DeploymentNote.java
  • src/main/java/io/grafeas/v1/DeploymentNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/DeploymentOccurrence.java
  • src/main/java/io/grafeas/v1/DeploymentOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/Discovery.java
  • src/main/java/io/grafeas/v1/DiscoveryNote.java
  • src/main/java/io/grafeas/v1/DiscoveryNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/DiscoveryOccurrence.java
  • src/main/java/io/grafeas/v1/DiscoveryOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/Distribution.java
  • src/main/java/io/grafeas/v1/DistributionOrBuilder.java
  • src/main/java/io/grafeas/v1/DsseAttestation.java
  • src/main/java/io/grafeas/v1/Envelope.java
  • src/main/java/io/grafeas/v1/EnvelopeOrBuilder.java
  • src/main/java/io/grafeas/v1/EnvelopeSignature.java
  • src/main/java/io/grafeas/v1/EnvelopeSignatureOrBuilder.java
  • src/main/java/io/grafeas/v1/FileHashes.java
  • src/main/java/io/grafeas/v1/FileHashesOrBuilder.java
  • src/main/java/io/grafeas/v1/Fingerprint.java
  • src/main/java/io/grafeas/v1/FingerprintOrBuilder.java
  • src/main/java/io/grafeas/v1/GerritSourceContext.java
  • src/main/java/io/grafeas/v1/GerritSourceContextOrBuilder.java
  • src/main/java/io/grafeas/v1/GetNoteRequest.java
  • src/main/java/io/grafeas/v1/GetNoteRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/GetOccurrenceNoteRequest.java
  • src/main/java/io/grafeas/v1/GetOccurrenceNoteRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/GetOccurrenceRequest.java
  • src/main/java/io/grafeas/v1/GetOccurrenceRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/GitSourceContext.java
  • src/main/java/io/grafeas/v1/GitSourceContextOrBuilder.java
  • src/main/java/io/grafeas/v1/GrafeasClient.java
  • src/main/java/io/grafeas/v1/GrafeasOuterClass.java
  • src/main/java/io/grafeas/v1/GrafeasSettings.java
  • src/main/java/io/grafeas/v1/Hash.java
  • src/main/java/io/grafeas/v1/HashOrBuilder.java
  • src/main/java/io/grafeas/v1/Image.java
  • src/main/java/io/grafeas/v1/ImageNote.java
  • src/main/java/io/grafeas/v1/ImageNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/ImageOccurrence.java
  • src/main/java/io/grafeas/v1/ImageOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/InTotoProvenance.java
  • src/main/java/io/grafeas/v1/InTotoProvenanceOrBuilder.java
  • src/main/java/io/grafeas/v1/InTotoProvenanceProto.java
  • src/main/java/io/grafeas/v1/InTotoStatement.java
  • src/main/java/io/grafeas/v1/InTotoStatementOrBuilder.java
  • src/main/java/io/grafeas/v1/InTotoStatementProto.java
  • src/main/java/io/grafeas/v1/Jwt.java
  • src/main/java/io/grafeas/v1/JwtOrBuilder.java
  • src/main/java/io/grafeas/v1/Layer.java
  • src/main/java/io/grafeas/v1/LayerOrBuilder.java
  • src/main/java/io/grafeas/v1/ListNoteOccurrencesRequest.java
  • src/main/java/io/grafeas/v1/ListNoteOccurrencesRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/ListNoteOccurrencesResponse.java
  • src/main/java/io/grafeas/v1/ListNoteOccurrencesResponseOrBuilder.java
  • src/main/java/io/grafeas/v1/ListNotesRequest.java
  • src/main/java/io/grafeas/v1/ListNotesRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/ListNotesResponse.java
  • src/main/java/io/grafeas/v1/ListNotesResponseOrBuilder.java
  • src/main/java/io/grafeas/v1/ListOccurrencesRequest.java
  • src/main/java/io/grafeas/v1/ListOccurrencesRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/ListOccurrencesResponse.java
  • src/main/java/io/grafeas/v1/ListOccurrencesResponseOrBuilder.java
  • src/main/java/io/grafeas/v1/Location.java
  • src/main/java/io/grafeas/v1/LocationOrBuilder.java
  • src/main/java/io/grafeas/v1/Metadata.java
  • src/main/java/io/grafeas/v1/MetadataOrBuilder.java
  • src/main/java/io/grafeas/v1/NonCompliantFile.java
  • src/main/java/io/grafeas/v1/NonCompliantFileOrBuilder.java
  • src/main/java/io/grafeas/v1/Note.java
  • src/main/java/io/grafeas/v1/NoteKind.java
  • src/main/java/io/grafeas/v1/NoteName.java
  • src/main/java/io/grafeas/v1/NoteOrBuilder.java
  • src/main/java/io/grafeas/v1/Occurrence.java
  • src/main/java/io/grafeas/v1/OccurrenceName.java
  • src/main/java/io/grafeas/v1/OccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/Package.java
  • src/main/java/io/grafeas/v1/PackageNote.java
  • src/main/java/io/grafeas/v1/PackageNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/PackageOccurrence.java
  • src/main/java/io/grafeas/v1/PackageOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/ProjectName.java
  • src/main/java/io/grafeas/v1/ProjectRepoId.java
  • src/main/java/io/grafeas/v1/ProjectRepoIdOrBuilder.java
  • src/main/java/io/grafeas/v1/Provenance.java
  • src/main/java/io/grafeas/v1/Recipe.java
  • src/main/java/io/grafeas/v1/RecipeOrBuilder.java
  • src/main/java/io/grafeas/v1/RelatedUrl.java
  • src/main/java/io/grafeas/v1/RelatedUrlOrBuilder.java
  • src/main/java/io/grafeas/v1/RepoId.java
  • src/main/java/io/grafeas/v1/RepoIdOrBuilder.java
  • src/main/java/io/grafeas/v1/Severity.java
  • src/main/java/io/grafeas/v1/Signature.java
  • src/main/java/io/grafeas/v1/SignatureOrBuilder.java
  • src/main/java/io/grafeas/v1/SlsaProvenance.java
  • src/main/java/io/grafeas/v1/SlsaProvenanceOrBuilder.java
  • src/main/java/io/grafeas/v1/SlsaProvenanceOuterClass.java
  • src/main/java/io/grafeas/v1/Source.java
  • src/main/java/io/grafeas/v1/SourceContext.java
  • src/main/java/io/grafeas/v1/SourceContextOrBuilder.java
  • src/main/java/io/grafeas/v1/SourceOrBuilder.java
  • src/main/java/io/grafeas/v1/Subject.java
  • src/main/java/io/grafeas/v1/SubjectOrBuilder.java
  • src/main/java/io/grafeas/v1/UpdateNoteRequest.java
  • src/main/java/io/grafeas/v1/UpdateNoteRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/UpdateOccurrenceRequest.java
  • src/main/java/io/grafeas/v1/UpdateOccurrenceRequestOrBuilder.java
  • src/main/java/io/grafeas/v1/Upgrade.java
  • src/main/java/io/grafeas/v1/UpgradeDistribution.java
  • src/main/java/io/grafeas/v1/UpgradeDistributionOrBuilder.java
  • src/main/java/io/grafeas/v1/UpgradeNote.java
  • src/main/java/io/grafeas/v1/UpgradeNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/UpgradeOccurrence.java
  • src/main/java/io/grafeas/v1/UpgradeOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/Version.java
  • src/main/java/io/grafeas/v1/VersionOrBuilder.java
  • src/main/java/io/grafeas/v1/Vulnerability.java
  • src/main/java/io/grafeas/v1/VulnerabilityNote.java
  • src/main/java/io/grafeas/v1/VulnerabilityNoteOrBuilder.java
  • src/main/java/io/grafeas/v1/VulnerabilityOccurrence.java
  • src/main/java/io/grafeas/v1/VulnerabilityOccurrenceOrBuilder.java
  • src/main/java/io/grafeas/v1/WindowsUpdate.java
  • src/main/java/io/grafeas/v1/WindowsUpdateOrBuilder.java
  • src/main/java/io/grafeas/v1/package-info.java
  • src/main/proto/grafeas/v1/compliance.proto
  • src/main/proto/grafeas/v1/cvss.proto
  • src/main/proto/grafeas/v1/discovery.proto
  • src/main/proto/grafeas/v1/vulnerability.proto
  • src/test/java/io/grafeas/v1/GrafeasClientTest.java
  • src/test/java/io/grafeas/v1/MockGrafeas.java
  • src/test/java/io/grafeas/v1/MockGrafeasImpl.java

@product-auto-label product-auto-label bot added the api: containeranalysis Issues related to the googleapis/java-grafeas API. label Feb 18, 2022
@suztomo
Copy link
Member Author

suztomo commented Feb 18, 2022 •
edited
Loading

Oh I might not be able to update owlbot-controlled files...

@suztomo suztomo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@suztomo
Copy link
Member Author

suztomo commented Feb 18, 2022

The windows build succeeded. Nice.

@suztomo suztomo merged commit e38125e into googleapis:main Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: containeranalysis Issues related to the googleapis/java-grafeas API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo @Neenu1995 @yoshi-kokoro