docs: Update SpannerSample.java to align with best practices by adhiggs · Pull Request #3625 · googleapis/java-spanner

adhiggs · 2025-02-01T02:29:27Z

docs: update SpannerSample.java to align with best practices

Encapsulates both ResultSet statements in try-with-resources statements to align with best practices.

Fixes #3623 ☕️

Encapsulates both statements in a try-with-resources statement

adhiggs · 2025-02-01T02:50:32Z

I don't work with github very often, so if I can get a hand in getting the tests passed, I would greatly appreciate it.

sakthivelmanii · 2025-02-05T09:39:08Z

@adhiggs please update your commit message to follow the convention. https://www.conventionalcommits.org/en/v1.0.0/

adhiggs · 2025-02-10T22:57:19Z

@adhiggs please update your commit message to follow the convention. https://www.conventionalcommits.org/en/v1.0.0/

@sakthivelmanii - I think I got it? PTAL.

adhiggs · 2025-05-13T20:00:40Z

@sakthivelmanii - Could you take a look at this request?

sakthivelmanii

Please fix the code issue

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java

sakthivelmanii · 2025-05-15T10:15:53Z

Please fix the checkstyle issues.

Error:  src/main/java/com/example/spanner/SpannerSample.java:[685,7] (indentation) Indentation: 'while' has incorrect indentation level 6, expected level should be 8.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[686,[9](https://github.com/googleapis/java-spanner/actions/runs/15027603684/job/42257173380?pr=3625#step:4:10)] (indentation) Indentation: 'while' child has incorrect indentation level 8, expected level should be 10.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[689,7] (indentation) Indentation: 'while rcurly' has incorrect indentation level 6, expected level should be 8.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[690,5] (indentation) Indentation: 'try rcurly' has incorrect indentation level 4, expected level should be 6.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[691,5] (indentation) Indentation: 'try' has incorrect indentation level 4, expected level should be 6.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[694,7] (indentation) Indentation: 'while' has incorrect indentation level 6, expected level should be 8.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[695,9] (indentation) Indentation: 'while' child has incorrect indentation level 8, expected level should be [10](https://github.com/googleapis/java-spanner/actions/runs/15027603684/job/42257173380?pr=3625#step:4:11).
Error:  src/main/java/com/example/spanner/SpannerSample.java:[698,7] (indentation) Indentation: 'while rcurly' has incorrect indentation level 6, expected level should be 8.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[699,5] (indentation) Indentation: 'try rcurly' has incorrect indentation level 4, expected level should be 6.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[700,3] (indentation) Indentation: 'try rcurly' has incorrect indentation level 2, expected level should be 4.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[701,1] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 0, expected level should be 2.
Error:  src/main/java/com/example/spanner/SpannerSample.java:[702,1] (indentation) CommentsIndentation: Comment has incorrect indentation level 0, expected is 2, indentation should be the same level as line 705.
Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (default-cli) on project spanner-snippets: You have [12](https://github.com/googleapis/java-spanner/actions/runs/15027603684/job/42257173380?pr=3625#step:4:13) Checkstyle violations. -> [Help 1]

https://github.com/googleapis/java-spanner/actions/runs/15027603684/job/42257173380?pr=3625

Fix spacing linter errors

adhiggs · 2025-05-27T21:39:25Z

Thanks for your patience! Spacing issuse should be sorted.

Clear Linter errors for indent

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.95.1` -> `6.96.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.29.2` -> `2.30.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.50.0` -> `1.50.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.96.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6960-2025-06-27) ##### Features - Allow JDBC to configure directpath for connection ([#3929](googleapis/java-spanner#3929)) ([d754f1f](googleapis/java-spanner@d754f1f)) - Support getOrNull and getOrDefault in Struct ([#3914](googleapis/java-spanner#3914)) ([1dc5a3e](googleapis/java-spanner@1dc5a3e)) - Use multiplexed sessions for read-only transactions ([#3917](googleapis/java-spanner#3917)) ([37fdc27](googleapis/java-spanner@37fdc27)) ##### Bug Fixes - Allow zero durations to be set for connections ([#3916](googleapis/java-spanner#3916)) ([43ea4fa](googleapis/java-spanner@43ea4fa)) ##### Documentation - Add snippet for Repeatable Read configuration at client and transaction ([#3908](googleapis/java-spanner#3908)) ([ff3d212](googleapis/java-spanner@ff3d212)) - Update SpannerSample.java to align with best practices ([#3625](googleapis/java-spanner#3625)) ([7bfc62d](googleapis/java-spanner@7bfc62d)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.30.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2300-2025-06-26) ##### Features - Enable grpc configurator for client-side tracing ([#1886](googleapis/java-datastore#1886)) ([97004c8](googleapis/java-datastore@97004c8)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.60.0 ([#1799](googleapis/java-datastore#1799)) ([bf2a33c](googleapis/java-datastore@bf2a33c)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.0 ([#1897](googleapis/java-datastore#1897)) ([a8d99cd](googleapis/java-datastore@a8d99cd)) - Update googleapis/sdk-platform-java action to v2.59.1 ([#1880](googleapis/java-datastore#1880)) ([4fb9929](googleapis/java-datastore@4fb9929)) - Update googleapis/sdk-platform-java action to v2.60.0 ([#1898](googleapis/java-datastore#1898)) ([0921f86](googleapis/java-datastore@0921f86)) </details> <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.14.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3140) *2025-06-28* - Upgrade: \[kotlinx-datetime 0.7.0]\[datetime\_0\_7\_0]. This impacts the `okio-fakefilesystem` artifact only. This is a binary-incompatible backwards-incompatible change that cannot co-exist with previous releases of `okio-fakefilesystem`! If you observe a `NoSuchMethodError` calling `FakeFileSystem.init`, update the calling code to this release (or newer) and recompile. We don't like imposing backwards-incompatible changes like this on you and do so regretfully. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.1): 1.50.1 ### Components #### Build & Tooling - ✨ Migrate publishing to Maven Central Portal ([#9054](DataDog/dd-trace-java#9054) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Drop Baggage when `TracePropagationBehaviorExtract=IGNORE` ([#9052](DataDog/dd-trace-java#9052) - [@mhlidd](https://github.com/mhlidd)) #### Tracer public API - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#9050](DataDog/dd-trace-java#9050) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#9049](DataDog/dd-trace-java#9049) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e80867de3af2534eca79fe17a33f5c76801bcd6a

Update SpannerSample.java

a06345e

Encapsulates both statements in a try-with-resources statement

adhiggs requested a review from a team February 1, 2025 02:29

adhiggs requested a review from a team as a code owner February 1, 2025 02:29

product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 1, 2025

adhiggs changed the title ~~Update SpannerSample.java~~ fix: Update SpannerSample.java to align with best practices Feb 1, 2025

adhiggs changed the title ~~fix: Update SpannerSample.java to align with best practices~~ fix:Update SpannerSample.java to align with best practices Feb 1, 2025

adhiggs changed the title ~~fix:Update SpannerSample.java to align with best practices~~ docs: Update SpannerSample.java to align with best practices Feb 1, 2025

Merge branch 'main' into main

34f9e43

adhiggs and others added 8 commits February 11, 2025 11:51

Merge branch 'main' into main

6c46a98

Merge branch 'main' into main

854482a

Merge branch 'main' into main

094213c

Merge branch 'main' into main

ed135f3

Merge branch 'main' into main

e0f488b

Merge branch 'main' into main

d4b219f

Merge branch 'main' into main

b7a23a8

Merge branch 'main' into main

7bc73a1

sakthivelmanii previously approved these changes May 14, 2025

View reviewed changes

sakthivelmanii reviewed May 14, 2025

View reviewed changes

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java Outdated Show resolved Hide resolved

sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2025

Update SpannerSample.java

c962cd2

sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2025

adhiggs dismissed sakthivelmanii’s stale review via c962cd2 May 15, 2025 17:47

adhiggs added 2 commits May 27, 2025 14:37

Update SpannerSample.java

9b8a930

Fix spacing linter errors

Merge branch 'main' into main

df1a5cb

adhiggs and others added 4 commits May 29, 2025 11:21

Update SpannerSample.java

258df5c

Clear Linter errors for indent

Merge branch 'main' into main

ccfe6e2

Merge branch 'main' into main

adade12

Merge branch 'main' into main

83d7b88

sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2025

sakthivelmanii approved these changes Jun 17, 2025

View reviewed changes

rahul2393 approved these changes Jun 17, 2025

View reviewed changes

rahul2393 merged commit 7bfc62d into googleapis:main Jun 17, 2025
33 of 35 checks passed

release-please bot mentioned this pull request Jun 23, 2025

chore(main): release 6.96.0 #3923

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Update SpannerSample.java to align with best practices#3625

docs: Update SpannerSample.java to align with best practices#3625
rahul2393 merged 17 commits intogoogleapis:mainfrom
adhiggs:main

adhiggs commented Feb 1, 2025 •

edited

Loading

Uh oh!

adhiggs commented Feb 1, 2025

Uh oh!

sakthivelmanii commented Feb 5, 2025

Uh oh!

adhiggs commented Feb 10, 2025 •

edited

Loading

Uh oh!

adhiggs commented May 13, 2025 •

edited

Loading

Uh oh!

sakthivelmanii left a comment

Uh oh!

Uh oh!

sakthivelmanii commented May 15, 2025 •

edited

Loading

Uh oh!

adhiggs commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adhiggs commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhiggs commented Feb 1, 2025

Uh oh!

sakthivelmanii commented Feb 5, 2025

Uh oh!

adhiggs commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhiggs commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sakthivelmanii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sakthivelmanii commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhiggs commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adhiggs commented Feb 1, 2025 •

edited

Loading

adhiggs commented Feb 10, 2025 •

edited

Loading

adhiggs commented May 13, 2025 •

edited

Loading

sakthivelmanii commented May 15, 2025 •

edited

Loading