Conversation
55663fb to
682eb09
Compare
682eb09 to
63d128b
Compare
mikelehen
approved these changes
Sep 29, 2018
Contributor
mikelehen
left a comment
There was a problem hiding this comment.
Refreshingly small PR. 😛
This basically LGTM, but we should probably hold off submitting until we discuss the API.
| * } else { | ||
| * missingDocuments++; | ||
| * } | ||
| * } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dev/test/collection.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| it('hast list() method', () => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
types/firestore.d.ts
Outdated
| * The document references returned may include missing documents, which | ||
| * are documents that have not been explicitly created but contain | ||
| * subcollections. If you attempt to read a missing document, we will return | ||
| * a DocumentSnapshot whose `.exists` property is set to false. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Still LGTM. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the ListDocuments RPC, which allows us to enumerate all documents, including missing documents. We only return DocumentReference and don't fetch any data.