docs: created samples for load table and create table from schema file#1436
Merged
docs: created samples for load table and create table from schema file#1436
Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
tswast
requested changes
Dec 12, 2022
Contributor
tswast
left a comment
There was a problem hiding this comment.
@Mattix23 @thejaredchapman We are getting some type checking failures. I've made some suggested edits that might fix this.
nox > Running session mypy_samples
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/mypy_samples
nox > python -m pip install -e '.[all]'
nox > python -m pip install ipython pytest
nox > python -m pip install mypy==0.910
nox > python -m pip install types-mock types-pytz
nox > python -m pip install typing-extensions
nox > mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/
samples/snippets/load_table_schema_from_json.py:18: error: Function is missing a return type annotation
samples/snippets/load_table_schema_from_json.py:37: error: Incompatible types in assignment (expression has type "Path", variable has type "str")
samples/snippets/create_table_schema_from_json.py:18: error: Function is missing a return type annotation
samples/snippets/create_table_schema_from_json.py:34: error: Incompatible types in assignment (expression has type "Path", variable has type "str")
Found 4 errors in 2 files (checked 212 source files)
nox > Command mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/ failed with exit code 1
nox > Session mypy_samples failed.
Co-authored-by: Tim Swast <swast@google.com>
tswast
requested changes
Dec 13, 2022
Contributor
tswast
left a comment
There was a problem hiding this comment.
One minor change, otherwise looking good!
Co-authored-by: Tim Swast <swast@google.com>
tswast
approved these changes
Dec 13, 2022
This was referenced Jan 24, 2023
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
googleapis#1436) * docs: created samples for load table and create table from schema file * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestions from code review Co-authored-by: Tim Swast <swast@google.com> * Update samples/snippets/create_table_schema_from_json.py Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #1069 🦕