Skip to content

docs: revise create table cmek sample#1452

Merged
tswast merged 4 commits intomainfrom
issue790-create_table_cmek
Jan 6, 2023
Merged

docs: revise create table cmek sample#1452
tswast merged 4 commits intomainfrom
issue790-create_table_cmek

Conversation

@Mattix23
Copy link
Contributor

@Mattix23 Mattix23 commented Jan 3, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@Mattix23 Mattix23 requested a review from a team January 3, 2023 20:48
@Mattix23 Mattix23 requested review from a team as code owners January 3, 2023 20:48
@Mattix23 Mattix23 requested a review from loferris January 3, 2023 20:48
@snippet-bot
Copy link

snippet-bot bot commented Jan 3, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 3, 2023
parthea
parthea reviewed Jan 4, 2023
View reviewed changes
@tswast
Copy link
Contributor

tswast commented Jan 4, 2023

Merging blocked by #1453

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
tswast
tswast approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've granted what I believe to be the necessary permissions in the cloud-samples-tests project to address the failures in the Samples test session.

@tswast tswast enabled auto-merge (squash) January 6, 2023 19:59
@tswast tswast merged commit 57740e4 into main Jan 6, 2023
@tswast tswast deleted the issue790-create_table_cmek branch January 6, 2023 20:25
@release-please release-please bot mentioned this pull request Jan 6, 2023
Merged
This was referenced Jan 24, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @gcf-owl-bot
@parthea @abdelmegahedgoogle
docs: revise create table cmek sample (googleapis#1452)
579bcda 
* docs: revise create table cmek sample

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea left review comments

@tswast tswast tswast approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mattix23 @tswast @parthea @yoshi-kokoro