refactor: split pandas system tests to new module#548
Merged
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:masterfrom Mar 15, 2021
Merged
refactor: split pandas system tests to new module#548gcf-merge-on-green[bot] merged 4 commits intogoogleapis:masterfrom
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:masterfrom
Conversation
plamut
suggested changes
Mar 12, 2021
Contributor
plamut
left a comment
There was a problem hiding this comment.
I like how the system tests are getting some structure. 👍 I think it's good, but I did spot an incorrectly converted assertion.
BTW, in the future, I suggest keeping related changes in their own commits, as it makes it easier to glance over the diff and directly see the key differences. That assertion conversion could have been easily overlooked.
plamut
approved these changes
Mar 15, 2021
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Follow-up to #448
Towards #366