Skip to content

test: look for transaction info on child job, not parent job#978

Merged
plamut merged 3 commits intogoogleapis:mainfrom
tswast:issue975-transaction_info
Sep 21, 2021
Merged

test: look for transaction info on child job, not parent job#978
plamut merged 3 commits intogoogleapis:mainfrom
tswast:issue975-transaction_info

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 21, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #975 🦕

@tswast tswast requested a review from a team September 21, 2021 14:39
@tswast tswast requested a review from a team as a code owner September 21, 2021 14:39
@tswast tswast requested a review from shollyman September 21, 2021 14:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 21, 2021
plamut
plamut approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that was it? We might want to document that in the property's docstring?

Edit: And maybe also here in the product docs (it's not obvious that a parent job is not part of the multi-statement transaction, at least not to me 🙃 ).

@tswast
Copy link
Contributor Author

tswast commented Sep 21, 2021

So that was it? We might want to document that in the property's docstring?

That's the theory. According to a backend engineer "Script parent job is not part of the transaction started in the script. And a script can create multiple transactions, e.g., many BEGIN TRANSACTION; ...; COMMIT TRANSACTION; blocks."

Good idea, re: docstring. Added!

plamut
plamut approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick docstring update!

One nit, but not essential.

@tswast
Copy link
Contributor Author

tswast commented Sep 21, 2021

Sent internal CL 397996384 for review to update the REST API docs.

@plamut plamut merged commit fcd6336 into googleapis:main Sep 21, 2021
@tswast tswast deleted the issue975-transaction_info branch September 21, 2021 20:49
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@tswast @abdelmegahedgoogle
test: look for transaction info on child job, not parent job (googlea…
f24e257 
…pis#978)

* test: look for transaction info on child job, not parent job

* clarify transaction_info docstring

* use sphinx method directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

2 more reviewers

@crwilcox crwilcox crwilcox approved these changes

@plamut plamut plamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test TestBigQuery.test_transaction_info is flaky.

3 participants

@tswast @crwilcox @plamut