Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

fix: avoid opening write stream more than once, make open method private#305

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
tswast:write-client-open-conflict
Sep 20, 2021
Merged

fix: avoid opening write stream more than once, make open method private#305
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
tswast:write-client-open-conflict

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 20, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested a review from a team September 20, 2021 18:42
@tswast tswast requested a review from a team as a code owner September 20, 2021 18:42
@tswast tswast requested a review from loferris September 20, 2021 18:42
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Sep 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
@tswast tswast requested a review from shollyman September 20, 2021 18:48
shollyman
shollyman approved these changes Sep 20, 2021
View reviewed changes
google/cloud/bigquery_storage_v1beta2/writer.py
self._futures_queue = queue.Queue()
self._inital_request_template = initial_request_template
self._metadata = metadata
self._opening = threading.Lock()
Copy link
Contributor

@shollyman shollyman Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend documenting here (and/or in _open) what the lock is actually guarding.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 58ec844 into googleapis:main Sep 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2021
@release-please
chore: release 2.9.0 (#303)
ccba144 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.9.0](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.8.0...v2.9.0) (2021-09-27)


### Features

* add `AppendRowsStream` to use write API from v1 endpoint ([#309](https://www.github.com/googleapis/python-bigquery-storage/issues/309)) ([9fc3c08](https://www.github.com/googleapis/python-bigquery-storage/commit/9fc3c08cdeebfbd69bc815f951a07b2d086b0a69))
* add BigQuery Storage Write API v1 ([#301](https://www.github.com/googleapis/python-bigquery-storage/issues/301)) ([69e3fb8](https://www.github.com/googleapis/python-bigquery-storage/commit/69e3fb8ec2ecac0417b6a4bc954004a064ae04b7))


### Bug Fixes

* add 'dict' annotation type to 'request' ([a778080](https://www.github.com/googleapis/python-bigquery-storage/commit/a7780805d7350855fccdcf2aefa596851ee83923))
* add missing read api retry setting on SplitReadStream ([#311](https://www.github.com/googleapis/python-bigquery-storage/issues/311)) ([66c09c0](https://www.github.com/googleapis/python-bigquery-storage/commit/66c09c01d643844117e3e35d2d90a6cc0491349e))
* avoid failure if closing `AppendRowsStream` before opening ([#304](https://www.github.com/googleapis/python-bigquery-storage/issues/304)) ([9f145f8](https://www.github.com/googleapis/python-bigquery-storage/commit/9f145f87d6a54e757044ff4110d2cafd57ce08fa))
* avoid opening write stream more than once, make open method private ([#305](https://www.github.com/googleapis/python-bigquery-storage/issues/305)) ([58ec844](https://www.github.com/googleapis/python-bigquery-storage/commit/58ec8444420d29c2915ec5b148de780a36eaf3e2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @shollyman