Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

feat: introduce compatibility with native namespace packages#706

Merged
Linchin merged 10 commits intogoogleapis:mainfrom
kiraksi:native-namespace-compatibility
Dec 1, 2023
Merged

feat: introduce compatibility with native namespace packages#706
Linchin merged 10 commits intogoogleapis:mainfrom
kiraksi:native-namespace-compatibility

Conversation

@kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Nov 14, 2023 •
edited
Loading

This PR:

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #705 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Nov 14, 2023
@kiraksi kiraksi self-assigned this Nov 14, 2023
@kiraksi kiraksi marked this pull request as ready for review November 14, 2023 00:52
@kiraksi kiraksi requested review from a team as code owners November 14, 2023 00:52
@kiraksi kiraksi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2023
@parthea
Copy link
Contributor

parthea commented Nov 14, 2023

There is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

parthea
parthea reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please could you also remove usage of pkg_resources here? Please feel free to make the change in this PR or a separate PR. This should allow us to close #482

python-bigquery-storage/tests/unit/test_reader_v1_arrow.py

Line 23 in 20b57c2

import pkg_resources

@kiraksi kiraksi linked an issue Nov 14, 2023 that may be closed by this pull request
DistributionNotFound error potentially caused by pkg_resources #482
Closed
@kiraksi kiraksi removed a link to an issue Nov 14, 2023
DistributionNotFound error potentially caused by pkg_resources #482
Closed
@kiraksi kiraksi force-pushed the native-namespace-compatibility branch from b47238d to a85ddca Compare November 14, 2023 17:44
@kiraksi
Copy link
Contributor Author

kiraksi commented Nov 14, 2023 •
edited
Loading

LGTM, please could you also remove usage of pkg_resources here? Please feel free to make the change in this PR or a separate PR. This should allow us to close #482

python-bigquery-storage/tests/unit/test_reader_v1_arrow.py

Line 23 in 20b57c2

import pkg_resources

Edit: Will be done in this PR

@kiraksi kiraksi linked an issue Nov 15, 2023 that may be closed by this pull request
DistributionNotFound error potentially caused by pkg_resources #482
Closed
parthea
parthea reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations. Otherwise LGTM

@kiraksi kiraksi requested a review from parthea November 16, 2023 18:34
@kiraksi kiraksi mentioned this pull request Nov 16, 2023
Closed
@kiraksi kiraksi mentioned this pull request Nov 16, 2023
Merged
4 tasks
@parthea parthea mentioned this pull request Nov 22, 2023
Closed
@kiraksi kiraksi removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 28, 2023
parthea
parthea suggested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to migrate setup.py to use setuptoolsfind_namespace_packages(.. instead of setuptools.PEP420PackageFinder.find()

@parthea parthea self-requested a review December 1, 2023 21:39
@Linchin Linchin merged commit 59f9564 into googleapis:main Dec 1, 2023
@release-please release-please bot mentioned this pull request Dec 1, 2023
Merged
@kiraksi kiraksi deleted the native-namespace-compatibility branch January 17, 2024 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

2 more reviewers

@parthea parthea parthea approved these changes

@Linchin Linchin Linchin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kiraksi kiraksi

Labels

api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use native support for namespace packages DistributionNotFound error potentially caused by pkg_resources

3 participants

@kiraksi @parthea @Linchin