[DRAFT] feat: use OperationTimeoutError instead of DeadlineExceeded#914
Closed
daniel-sanche wants to merge 5 commits intogoogleapis:experimental_v3from
Closed
[DRAFT] feat: use OperationTimeoutError instead of DeadlineExceeded#914daniel-sanche wants to merge 5 commits intogoogleapis:experimental_v3from
daniel-sanche wants to merge 5 commits intogoogleapis:experimental_v3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current v3 alpha, operations that exceed the timeout raise a
DeadlineExceedederror. This overloads the meanings of that error, since it is typically used to denote an expired rpc, not entire operation.This PR changes the exception raised to a new OperationTimeoutError, which is used only for timed out operations. The new exception is a subclass of
api_core.exceptions.RetryError, to align with other librariesFixes #913