Merged
Conversation
plamut
reviewed
Aug 27, 2021
plamut
left a comment
There was a problem hiding this comment.
There's a reference to master in .github/workflows/python-publish.yml, but that probably refers to the gh-action-pypi-publish repo.
steps:
...
- name: Publish Source Distribution
uses: pypa/gh-action-pypi-publish@master
However, I did find references to VERSION_WHITELIST in scripts/manylinux/build_on_centos.sh. I believe the inclusive language version of that should be VERSION_ALLOWLIST.
Since the purpose of master -> main migration is to address precisely these things, let's also address that in the same PR.
Contributor
Author
dandhlee
approved these changes
Aug 30, 2021
Contributor
|
Confirmed no other occurrences of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward: googleapis/google-cloud-python#10579